Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RV-386): Add login screen #506

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

knguyenrise8
Copy link
Collaborator

Description

login screen

Screenshots (if applicable)

Jan-09-2025 10-27-15

Related Issues

[Link any related issues or tasks from your project management system.]

Checklist

  • The title of this PR is descriptive and concise.
  • My changes follow the style guidelines of this project.
  • I have added or updated test cases to cover my changes.
  • I've let the team know about this PR by linking it in the review channel

try {
// Prevent default form behavior
const token = await mockLogin(data.email, data.password);
console.log(token)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

export const mockLogin = async (username: string, password: string) => {
// Simulate API call delay
await new Promise(resolve => setTimeout(resolve, 1000));
console.log('login', username, password);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably remove.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@arinkulshi-skylight arinkulshi-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! minor edits

@knguyenrise8 knguyenrise8 added this pull request to the merge queue Jan 10, 2025
@knguyenrise8
Copy link
Collaborator Author

LGTM! minor edits

thanks Arin made the updates

Merged via the queue into main with commit 98f4077 Jan 10, 2025
5 checks passed
@knguyenrise8 knguyenrise8 deleted the feat/RV-386-login-screen branch January 10, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants