-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RV-386): Add login screen #506
Conversation
try { | ||
// Prevent default form behavior | ||
const token = await mockLogin(data.email, data.password); | ||
console.log(token) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
export const mockLogin = async (username: string, password: string) => { | ||
// Simulate API call delay | ||
await new Promise(resolve => setTimeout(resolve, 1000)); | ||
console.log('login', username, password); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
420923d
to
069020d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! minor edits
thanks Arin made the updates |
Description
login screen
Screenshots (if applicable)
Related Issues
[Link any related issues or tasks from your project management system.]
Checklist