Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image alignment research code #69

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Add image alignment research code #69

merged 1 commit into from
Jun 13, 2024

Conversation

jonchang
Copy link
Collaborator

@jonchang jonchang commented Apr 5, 2024

Pull Request

Description

Adds research code related to the image alignment spike.

Related Issues

#7

Additional Notes

https://docs.google.com/document/d/12AibUgv1V7n3oiO5RQZxHE-PTrjKyHrsAQ6pVlar9i8/edit?usp=drive_link

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.
  • I have notified teammates in the review thread to build awareness.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

Copy link
Collaborator

@zdeveloper zdeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great start, I am just a bit unsure on how this will fit in with the rest of the application and how we will align an input image to a template considering we are just inputting one file

OCR/image-alignment/go.sh Outdated Show resolved Hide resolved
OCR/image-alignment/deskew.py Outdated Show resolved Hide resolved
OCR/image-alignment/deskew.py Outdated Show resolved Hide resolved
OCR/image-alignment/deskew.py Outdated Show resolved Hide resolved
OCR/image-alignment/deskew.py Outdated Show resolved Hide resolved
zdeveloper
zdeveloper previously approved these changes Apr 17, 2024
Copy link
Collaborator

@zdeveloper zdeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes

Copy link
Collaborator

@arinkulshi-skylight arinkulshi-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonchang jonchang added this pull request to the merge queue Jun 13, 2024
Merged via the queue into main with commit ae4f6f0 Jun 13, 2024
2 checks passed
@jonchang jonchang deleted the image-alignment branch June 13, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants