Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IDWA-OCR-96]Create segmentation template and labels file using PDF metadata #99

Merged
merged 32 commits into from
Jun 24, 2024
Merged

[IDWA-OCR-96]Create segmentation template and labels file using PDF metadata #99

merged 32 commits into from
Jun 24, 2024

Conversation

arinkulshi-skylight
Copy link
Collaborator

Pull Request

Description

#96

Checklist

Please review and complete the following checklist before submitting your pull request:

  • [x ] I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.
  • I have notified teammates in the review thread to build awareness.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@arinkulshi-skylight arinkulshi-skylight changed the title Idwa#96 Idwa#99 Apr 30, 2024
@arinkulshi-skylight arinkulshi-skylight linked an issue Apr 30, 2024 that may be closed by this pull request
Create segmentation template and labels file using PDF metadata #96
Closed
@arinkulshi-skylight arinkulshi-skylight removed a link to an issue Apr 30, 2024
Create segmentation template and labels file using PDF metadata #96
Closed
@arinkulshi-skylight arinkulshi-skylight linked an issue Apr 30, 2024 that may be closed by this pull request
Create segmentation template and labels file using PDF metadata #96
Closed
@arinkulshi-skylight arinkulshi-skylight changed the title Idwa#99 IDWA#96 Create segmentation template and labels file using PDF metadata May 2, 2024
@arinkulshi-skylight arinkulshi-skylight marked this pull request as ready for review May 2, 2024 22:33
@arinkulshi-skylight arinkulshi-skylight changed the title IDWA#96 Create segmentation template and labels file using PDF metadata [IDWA-OCR-96]Create segmentation template and labels file using PDF metadata May 14, 2024
zdeveloper
zdeveloper previously approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@zdeveloper zdeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

zdeveloper
zdeveloper approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@zdeveloper zdeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you!

@arinkulshi-skylight arinkulshi-skylight added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit f09b511 Jun 24, 2024
2 checks passed
@arinkulshi-skylight arinkulshi-skylight deleted the IDWA#96 branch June 24, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdeveloper zdeveloper zdeveloper approved these changes

@jonchang jonchang Awaiting requested review from jonchang

@knguyenrise8 knguyenrise8 Awaiting requested review from knguyenrise8

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create segmentation template and labels file using PDF metadata
3 participants
@arinkulshi-skylight @zdeveloper @arinkulshi