Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing default sigfigs in app to 2 #74

Merged
merged 2 commits into from
Jan 15, 2025
Merged

changing default sigfigs in app to 2 #74

merged 2 commits into from
Jan 15, 2025

Conversation

paigemiller
Copy link
Contributor

Changing from default 3 to default 2 and the maximum is now 3 rather than 4.

@paigemiller paigemiller requested a review from swo January 13, 2025 17:08
@paigemiller paigemiller linked an issue Jan 13, 2025 that may be closed by this pull request
Check input & output numbers of sigfigs/rounding #69
Closed
swo
swo reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@swo swo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the default number of significant digits, but it seems like the NGM table is not rounded using them?

image

All the other results seem fine. Not sure if that's meant to be another PR, but I think we can just fix it here.

@paigemiller paigemiller requested a review from swo January 14, 2025 21:25
@paigemiller paigemiller merged commit 3b07f61 into main Jan 15, 2025
2 checks passed
@paigemiller paigemiller deleted the pm_sigfigs branch January 15, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swo swo swo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check input & output numbers of sigfigs/rounding
2 participants
@paigemiller @swo