Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor summarization #45

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Refactor summarization #45

merged 3 commits into from
Dec 19, 2024

Conversation

swo
Copy link
Contributor

@swo swo commented Dec 18, 2024

  • Use a polars schema, rather than casting
  • Write get_all_person_properties() as a list comprehension, adding simulation index after the constituent data frames are made
  • For the intermediate function that gets person properties from one simulation, use pl.from_dicts()
  • Rewrite prepare_for_df as a dict comprehension

Builds on top of #44 , which should likely be merged first

@swo swo requested a review from afmagee42 December 18, 2024 23:04
@swo swo marked this pull request as ready for review December 18, 2024 23:04
Base automatically changed from afm-report-termination-swo-tests to afm-report-termination December 19, 2024 15:05
ringvax/summary.py Show resolved Hide resolved
ringvax/summary.py Show resolved Hide resolved
@swo swo force-pushed the swo_summary_refactor branch from 8a12f18 to 0a1b1a4 Compare December 19, 2024 16:48
@swo swo merged commit 2c594b7 into afm-report-termination Dec 19, 2024
2 checks passed
@swo swo deleted the swo_summary_refactor branch December 19, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants