Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24 and #15. Solves #53 along the way because the broken plots that led to were driving me crazy.
Code lives in
ringvax.plot
, and I'm rather tempted to wrap it all up into a plotting object since that would avoid a lot of unneeded passing of objects around (the simulation, plotting parameters, and the plot itself).Colors and styles can and probably should be argued over. I strove to keep things clean and visible first and foremost, but also to use our color palette and keep things accessible. I think this is mostly achieved, except perhaps marking detections which is a bit ugly. I tried delineating detection types by color, instead of shape, but I ran out of colors that were both easy to see on both latent and exposed backgrounds and which were truly distinctive from each other.
To keep some of the plotting-induced post-processing sane, I added infection attributes: the
id
and theinfectees
.