-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More control over size histogram #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of small thoughts:
- I think it's easier to have the plot options next to the "Advanced options"? I like the sidebar having all the controls, and the main window being just results displayed
- Rather than changing the text above the plot (to adapt for # of generations and cumulative vs. not), I think it would be easier to have that be the x-axis title of the plot itself. Fewer places to look
- Weirdly, the altair plot doesn't break at integers. If this is easy to fix (or you think is worth breaking off into another issue that I tackle), we could look into it.
Co-authored-by: Scott Olesen <[email protected]>
Co-authored-by: Scott Olesen <[email protected]>
Co-authored-by: Scott Olesen <[email protected]>
The breaks on these altair histograms have annoyed me since #32 but I think better breaks is a follow-up issue, including:
I previously tried an altair title, and it was both too long (got chopped off) and mucked up the size of the displayed histogram. Now trying it as an x axis label, I see it merely leads to a truncation issue. If we can workshop a shorter (looks like 65 characters or less) and equally clear option, I am game for this.
|
"Cumulative infections through generation"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing. It even has a test!
Co-authored-by: Scott Olesen <[email protected]>
Resolves, more or less, #38 by giving users control over what they want the histogram to show. Users can now toggle between cumulative sizes and sizes in specific generations for any generation simulated.
Bonus out-of-scope bug fix:
app.render_percents()
was rounding wrong.