Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up a few things I found when trying to run the evaluation demo on a fresh repo copy.
The only actual bugs were:
with ..., save_path.open("wb") as out_file
otherwise errors on a fresh repository.The other changes are a bit more stylistic and/or pedantic:
data/README.md
with "see the help function" because we don't want to have multiple sources of truth (one is likely to end up out of sync otherwise).included-divisions.txt
an argument inload_metadata
with a default, rather than a strictly hard-coded value. In so doing, I decided the default place to call this from was the top level of the repo, rather than/data
.