-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YAML-run pipeline, part 2 (data preprocessing) #28
Conversation
While we're working on configurability, we also want to be able to configure an analysis to filter not just to data relevant to the forecast date ( |
We should also find a way to keep the forecast date around as a date, so that we can choose to plot things on a non-arbitrary-time-axis (that is, against something other than |
02bbd26
to
f2f1145
Compare
Done :) |
Done. And now that we're on this topic, I've updated the preprocessing script to give us two datasets for a given horizon
|
11dd887
to
2b43391
Compare
2b43391
to
e526d64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is solid progress towards easy running, but we've got to get some things cleared up first.
Co-authored-by: afmagee42 <[email protected]>
Co-authored-by: afmagee42 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: afmagee42 <[email protected]>
This resolves #26.
Until now, we've been missing the ability to easily configure how data is preprocessed.
The
linmod.data
script now accepts a single commandline argument for the path to a YAML file configuring its behavior. This is optional; without it, the default behavior (seen in the dictionarylinmod.data.DEFAULT_CONFIG
) will be used. The YAML file only needs to define the keys it wants to modify from default; missing keys will be populated with the default values.An example is given in
present-day-forecasting/config.yaml
. As described in the README, this is run aspython3 linmod.data config.yaml
.