Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data synchronization #33

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Data synchronization #33

merged 3 commits into from
Aug 20, 2024

Conversation

afmagee42
Copy link
Collaborator

This PR makes it so that present-day-forecasting/main.py generates its own dataset.

Previously our workflow was to first download the data, then run the present-day-forecasting/main.py. This allowed for the downloaded data to correspond to a time-horizon that was different from what was specified in present-day-forecasting/config.yaml.

I refactored linmod.data such that the functionality of linmod.data__main__ is now in a function linmod.data.main() which present-day-forecasting/main.py calls using the config it was provided.

@afmagee42 afmagee42 requested a review from thanasibakis August 19, 2024 20:39
@thanasibakis
Copy link
Collaborator

This is nice!

@thanasibakis thanasibakis merged commit 07268cf into main Aug 20, 2024
1 check passed
@thanasibakis thanasibakis deleted the afm-synch-data branch August 20, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants