Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hard-coded column names in daily_to_epiweekly() #56

Merged
merged 81 commits into from
Jan 27, 2025
Merged

Fix hard-coded column names in daily_to_epiweekly() #56

merged 81 commits into from
Jan 27, 2025

Conversation

dylanhmorris
Copy link
Collaborator

No description provided.

AFg6K7h4fhy2 and others added 30 commits November 25, 2024 14:45
@AFg6K7h4fhy2
start README update; start github action for rendering; render readme
9a7d8d6
@AFg6K7h4fhy2
update action checkout
db1688e
@AFg6K7h4fhy2
test out README rendering
b89576b
@AFg6K7h4fhy2
attempt fix action via add python setup
3a5d519
@AFg6K7h4fhy2
further test render README
a90adae
@AFg6K7h4fhy2
further modification of readme rendering
75e639b
@AFg6K7h4fhy2
display covid data
d06fe53
@AFg6K7h4fhy2
reorder workflow
bcc2238
@AFg6K7h4fhy2
another attempt at proper quarto poetry env
92f7c76
@github-actions
Auto-update README.md
415cafa
@AFg6K7h4fhy2
minor change to README
49a4dbe
@AFg6K7h4fhy2
Merge branch '19-action-to-use-quarto-for-readme-generation' of githu…
abb5de0 
…b.com:CDCgov/forecasttools-py into 19-action-to-use-quarto-for-readme-generation
@AFg6K7h4fhy2
attempt adoption of GVY recommendation
b7bea2e
@github-actions
Auto-update README.md
24ad144
@AFg6K7h4fhy2
attempt fix pre-commit with yaml; add to README
3f43520
@AFg6K7h4fhy2
Merge branch '19-action-to-use-quarto-for-readme-generation' of githu…
6667406 
…b.com:CDCgov/forecasttools-py into 19-action-to-use-quarto-for-readme-generation
@AFg6K7h4fhy2
add polars
bd6f65a
@github-actions
Auto-update README.md
e2a2624
@AFg6K7h4fhy2
clean README
7f23426
@AFg6K7h4fhy2
Merge branch '19-action-to-use-quarto-for-readme-generation' of githu…
7c1af72 
…b.com:CDCgov/forecasttools-py into 19-action-to-use-quarto-for-readme-generation
@github-actions
Auto-update README.md
efd38c4
@AFg6K7h4fhy2
use kable for dataframes; test details block
0b00fd6
@AFg6K7h4fhy2
use kable for dataframes; test details block
1701846
@github-actions
Auto-update README.md
17d6e29
@AFg6K7h4fhy2
attempt use of asis; remove kable; remove xarry extended formatting
9a702e8
@github-actions
Auto-update README.md
a368584
@AFg6K7h4fhy2
attempt w/ print statements over quarto formatting
5efc0f6
@AFg6K7h4fhy2
Merge branch '19-action-to-use-quarto-for-readme-generation' of githu…
27b1bc7 
…b.com:CDCgov/forecasttools-py into 19-action-to-use-quarto-for-readme-generation
@github-actions
Auto-update README.md
ee5e8b7
@AFg6K7h4fhy2
remove output asis; comment polars formatting; add print statements
fd09f39
AFg6K7h4fhy2 and others added 26 commits November 27, 2024 14:19
@AFg6K7h4fhy2
add exit codes
e0e4b46
@AFg6K7h4fhy2
change re-commit exit code
63eeca1
@AFg6K7h4fhy2
exit code test
050c966
@AFg6K7h4fhy2
remove quiet flag
b947661
@AFg6K7h4fhy2
update README.md for rendering
3ad5efb
@AFg6K7h4fhy2
remove comments; add space ignore
e2c366f
@AFg6K7h4fhy2
test comment; add no cache
094a667
@AFg6K7h4fhy2
quarto render to gfm
552e263
@AFg6K7h4fhy2
updated quarto
6c46d29
@AFg6K7h4fhy2
add back comments; remove explicit --to gfm
d11e378
@AFg6K7h4fhy2
add space to rand file, see speed
62ba720
@AFg6K7h4fhy2
set run always to true
ecac708
@AFg6K7h4fhy2
minor edits to flags and hook
bd6e361
@dylanhmorris
Update .pre-commit-config.yaml
8b9cc9b
@dylanhmorris
Rebase remote
47d4204
@dylanhmorris
Update pre-commit.yaml
798df64 
Need to poetry install explicitly or risk of hook failure after pre-commit-config change
@dylanhmorris
Render with latest quarto
7666544
@dylanhmorris
Remove poetry install call
cb6446e
@dylanhmorris
Do not run poetrty install within hook
f147cdd
@dylanhmorris
Run poetry install outside of hook
cf00289
@dylanhmorris
poetry install in hook
44b264b
@dylanhmorris
revert to no install in hook
1e66fc4
@dylanhmorris
Try with files: defined
95257d3
@dylanhmorris
Fix hard-coded column names in daily_to_epiweekly
228fe96
@dylanhmorris
Merge branch 'main' into dhm-fix-hardcoded-columns
c8c3906
@dylanhmorris
Merge branch 'main' into dhm-fix-hardcoded-columns
76b55db
AFg6K7h4fhy2
AFg6K7h4fhy2 approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@AFg6K7h4fhy2 AFg6K7h4fhy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Removing forecast from variable names seems sensible.
    • Original reasoning: the idata we are working with a forecasts.
  • Removal of hard-coded entries also sensible.

LGTM. Thank you very much @dylanhmorris !

@AFg6K7h4fhy2 AFg6K7h4fhy2 merged commit cca8f02 into main Jan 27, 2025
2 checks passed
@AFg6K7h4fhy2 AFg6K7h4fhy2 deleted the dhm-fix-hardcoded-columns branch January 27, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AFg6K7h4fhy2 AFg6K7h4fhy2 AFg6K7h4fhy2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanhmorris @AFg6K7h4fhy2