Start of the Web console #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ekr-cfa
force-pushed
the
ekr_debugger_web1
branch
from
93d8590 to
51c7e0c
Compare
ekr-cfa
force-pushed
the
ekr_debugger_web1
branch
from
51c7e0c to
4be5579
Compare
k88hudson-cfa
requested changes
Feb 7, 2025
|
|
||
| export default async function getApi() { | ||
| if (!api) { | ||
| api = await new Api(); |
There was a problem hiding this comment.
This is a bit weird in that it doesn't actually need to be async, but we could address that in a follow up
There was a problem hiding this comment.
I'd like to leave this as is in case we discover we do need an async phase.
static/app.js
Outdated
|
|
||
| function App() { | ||
| let app = makeAppState(); | ||
| let properties = ["InfectionStatus"]; |
There was a problem hiding this comment.
This looks unused I think
| let properties = ["InfectionStatus"]; | ||
|
|
||
| return html` | ||
| <div><${Time} app=${app} /></div> |
There was a problem hiding this comment.
These should actually be receiving the generation value (that's what useEffect should use to determine it should update) v.s. the update function – only things that trigger an update should get the update function (like the next button)
k88hudson-cfa
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very primitive Web console. The way it's structured is that there are a series of individual widgets each of which is responsible for displaying some aspect of the simulation. Each widget is individually responsible for retrieving its own information and showing it within its own region. The existing widgets are:
All of these use a shared API object that takes care of communication with the Ixa Web API.
Finally, there is a
nextbutton which runs the simulation to the next time step. This works by:next()API call withtset tot + 1.Note that this will not stop the next time that simulation time increments but rather the next time the simulation reenters the Web API at a time greater than the previous time. This is because the Web API doesn't respond to requests continuously but only when the simulation is paused. The reason for polling is because the request for the next time might time out (though I actually may need to suppress errors in this case, which I'm not sure I have done).