-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: setup playwright for e2e tests #3067
Open
BobanL
wants to merge
23
commits into
boban/2873-env-variables-next-runtime-env
Choose a base branch
from
boban/2969-e2e-tests
base: boban/2873-env-variables-next-runtime-env
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
test: setup playwright for e2e tests #3067
BobanL
wants to merge
23
commits into
boban/2873-env-variables-next-runtime-env
from
boban/2969-e2e-tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## boban/2873-env-variables-next-runtime-env #3067 +/- ##
=============================================================================
+ Coverage 87.80% 87.83% +0.03%
=============================================================================
Files 80 80
Lines 4041 4053 +12
Branches 670 675 +5
=============================================================================
+ Hits 3548 3560 +12
Misses 472 472
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. |
BobanL
changed the title
add playwright init and tests
test: setup playwright for e2e tests
Dec 19, 2024
This reverts commit bd080ec.
BobanL
requested review from
akasper,
angelathe,
austin-hall-skylight and
gordonfarrell
as code owners
December 19, 2024 17:30
BobanL
requested review from
JNygaard-Skylight,
lina-roth,
mcmcgrath13 and
robertmitchellv
as code owners
December 19, 2024 17:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review #3006 first
PULL REQUEST
Summary
Related Issue
Fixes #2969
Acceptance Criteria
Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)
Additional Information
Anything else the review team should know?
Checklist