Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: setup playwright for e2e tests #3067

Open
wants to merge 23 commits into
base: boban/2873-env-variables-next-runtime-env
Choose a base branch
from

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Dec 16, 2024

Review #3006 first

PULL REQUEST

Summary

  • Add playwright and create two test files for ecr-viewer and ecr-library
  • Add Job to run playwright tests in github actions
  • Remove makefile

Related Issue

Fixes #2969

Acceptance Criteria

Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.83%. Comparing base (837e55e) to head (a10734c).
Report is 9 commits behind head on boban/2873-env-variables-next-runtime-env.

Additional details and impacted files
@@                              Coverage Diff                              @@
##           boban/2873-env-variables-next-runtime-env    #3067      +/-   ##
=============================================================================
+ Coverage                                      87.80%   87.83%   +0.03%     
=============================================================================
  Files                                             80       80              
  Lines                                           4041     4053      +12     
  Branches                                         670      675       +5     
=============================================================================
+ Hits                                            3548     3560      +12     
  Misses                                           472      472              
  Partials                                          21       21              
Flag Coverage Δ
ecr-viewer 89.00% <ø> (+0.05%) ⬆️
orchestration 85.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@BobanL BobanL changed the title add playwright init and tests test: setup playwright for e2e tests Dec 19, 2024
@BobanL BobanL marked this pull request as ready for review December 19, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant