feat: wip - reset filters button #3085
Open
+239
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
(Note this is into PR #3084)
Add a
Reset
button when the filters are not in their default states. Make sure the reset button updates both the URL and the UI.This ended up being a tiny bit finnicky and is a "two step" process. 1. Update the URL. 2. Listen for URL updates to reset the UI. Suggestions for streamlining very welcome.
Related Issue
Fixes #2992
Acceptance Criteria
Reset
button should be visible in the filter barReset
button is clicked.Reset
button is clicked, then the filter box should close automatically.Reset
button should NOT appear in the filter barAdditional Information