Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align USA banner to new SR width #6103

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Align USA banner to new SR width #6103

merged 5 commits into from
Jul 12, 2023

Conversation

zdeveloper
Copy link
Contributor

@zdeveloper zdeveloper commented Jul 10, 2023 •
edited
Loading

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

  • align USA header to SR header
  • a follow up PR will address the alert

Testing

  • How should reviewers verify this PR? deployed on dev 6

Screenshots / Demos

  • before
Screenshot 2023-07-11 at 11 31 57 AM
  • after
Screenshot 2023-07-11 at 11 31 14 AM

@zdeveloper zdeveloper temporarily deployed to dev6 July 11, 2023 14:47 — with GitHub Actions Inactive
@zdeveloper zdeveloper changed the title align USA banner to new SR width Align USA banner to new SR width Jul 11, 2023
@zdeveloper zdeveloper marked this pull request as ready for review July 11, 2023 17:11
@nathancrtr
Copy link
Contributor

I noticed that when the alert is active, the SimpleReport banner logo loses its top margin and squishes into the USA banner:

Screen Shot 2023-07-11 at 2 43 46 PM

I see your notes for this PR say that a follow up PR will address the alert, so this may already be on your radar, but I just wanted to call it out.

@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zdeveloper zdeveloper merged commit f11c635 into main Jul 12, 2023
31 checks passed
@zdeveloper zdeveloper deleted the zedd/5976-align-banner branch July 12, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobanL BobanL BobanL approved these changes

@nathancrtr nathancrtr nathancrtr approved these changes

@DanielSass DanielSass Awaiting requested review from DanielSass

@mpbrown mpbrown Awaiting requested review from mpbrown

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zdeveloper @nathancrtr @BobanL