Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UP state addition template #8025

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

fzhao99
Copy link
Contributor

@fzhao99 fzhao99 commented Aug 12, 2024

Adding an issue template for new states to the UP as discussed in the 8/8 eng sync. New process will be

  • Once a state is added to the UP @jayna-SkylightDigital will create a ticket using this template and assign it to the oncall engineer.
  • Oncall engineer will complete the ticket and give her a pingback for any follow on product action items that need doing.\

Potential areas for improvement

  • Is there a way to auto-assign the relevant oncall eng (GitHub <> Pagerduty integration somehow?) rather than having someone having to manually look this up? If not, can we have a Slack command that spits back who's currently oncall?
    • Would need Pagerduty back to fully investigate this, pending the ONC discussion.
  • Would we want to have the person generating the list be the same person who's sending out the emails (ie Jayna generates the emails or the eng sets up the Sendgrid campaign)? Would eliminate one pass-back step in the process

@fzhao99 fzhao99 changed the title add template add UP state addition template Aug 12, 2024
Copy link

sonarcloud bot commented Aug 12, 2024

@fzhao99 fzhao99 marked this pull request as ready for review August 12, 2024 13:12
Updates are needed in the following areas:

- [ ] Update [the list of UP states](https://github.com/CDCgov/prime-simplereport-site/blob/a745bf8383ae9c0a10dcfa26a48340dd9c905d64/_config.yml#L61) on the static site config. Refer to [this PR](https://github.com/CDCgov/prime-simplereport-site/blob/a745bf8383ae9c0a10dcfa26a48340dd9c905d64/_config.yml#L61) for an example
- [ ] Generate the list of admin emails senders in that state for product to make an announcement using the `sendOrgAdminEmailCSV` mutation. Notify product once this list is generated so they can continue with the email campaign.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it is helpful here is a link to how to perform the mutation: https://github.com/cdcent/simplereport_docs/wiki/Support-requests#generating-outreach-email-csvs

Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you bob!

Copy link
Collaborator

@bobbywells52 bobbywells52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for getting this up so quickly!

@fzhao99 fzhao99 added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 0fb33a4 Aug 12, 2024
33 checks passed
@fzhao99 fzhao99 deleted the bob/add-up-update-issue-template branch August 12, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants