Add disease specific AOE tab for bulk upload guide #8165

mpbrown · 2024-10-01T16:22:04Z

FRONTEND PULL REQUEST

Related Issue

Resolves [Bulk Upload Guide] Add Disease-specific labels #7726

Changes Proposed

Adds disease tab feature to CSV documentation sections
Converts CsvSchemaItem to use a RequiredStatusTag enum instead of combinations of required and requested
Removes requested in favor of optional

Additional Information

Ignore the "Duplicated Lines" warning from SonarLint since we are defining the documentation schema data

Testing

Deployed on dev6

Screenshots / Demos

mpbrown · 2024-10-03T16:41:50Z

frontend/src/app/testResults/uploads/CsvSchemaDocumentation.test.tsx

+      );
+      const user = userEvent.setup();
+
+      expect(screen.getAllByText("Required for Positives")).toHaveLength(1);


⚠️ expecting it to have length 1 because we use the Required for Positives tag in the explanation of how the tags work at the start of the guide

frontend/src/app/testResults/uploads/CsvSchemaDocumentation.scss

emyl3 · 2024-10-04T03:01:53Z

frontend/src/app/testResults/uploads/specificSchemaBuilder.ts

+              {
+                title: MULTIPLEX_DISEASES.HIV,
+                slug: MULTIPLEX_DISEASES.HIV,
+                items: [


In this PR are we addressing the HIV AOE questions or just adding the disease specific AOE tabs?

Because if we want the guide to reflect what is required we should add genders of sexual partners.

Let me know what you think! 👀

Just adding disease specific AOE tabs for this ticket, but #7461 is in the parking lot for adding the content for new AOE like genders of sexual partners

emyl3

Nice work on the implementation of this, Mike! I left a couple comments/questions for you!

emyl3

LGTM! Thank you!!

mehansen · 2024-10-08T17:31:49Z

I can't tell from the original ticket, but did we want the non-relevant AOE questions for a disease to even show in that tab? e.g. employed_in_healthcare is not something receivers are even interested in for HIV, and it's not part of the AOE on the test card for HIV devices, so I would think we don't even need to show it as an AOE question for HIV

bobbywells52

LGTM thanks for your great work on this!

mpbrown · 2024-10-08T19:55:44Z

@mehansen I checked with Jayna and we're good to remove those AOE columns for HIV, so I just updated it here

emyl3 · 2024-10-09T21:19:35Z

I can't tell from the original ticket, but did we want the non-relevant AOE questions for a disease to even show in that tab? e.g. employed_in_healthcare is not something receivers are even interested in for HIV, and it's not part of the AOE on the test card for HIV devices, so I would think we don't even need to show it as an AOE question for HIV

(unrelated to your changes @mpbrown 😅)
Even though the receivers aren't interested, don't we technically still send employed_in_healthcare and resident_congregate_setting within patient_data for single entry tests regardless of disease? Is this something we need to clean up? 🤔

We also have some columns like icu, residence_type, and hospitalized that (I think...) we no longer ask for or send on the single entry side of things, is this something we also need to clean up/align with our bulk results upload? 🧐

emyl3

LGTM! Tested locally!

mehansen · 2024-10-10T20:49:09Z

I can't tell from the original ticket, but did we want the non-relevant AOE questions for a disease to even show in that tab? e.g. employed_in_healthcare is not something receivers are even interested in for HIV, and it's not part of the AOE on the test card for HIV devices, so I would think we don't even need to show it as an AOE question for HIV

(unrelated to your changes @mpbrown 😅) Even though the receivers aren't interested, don't we technically still send employed_in_healthcare and resident_congregate_setting within patient_data for single entry tests regardless of disease? Is this something we need to clean up? 🤔

We also have some columns like icu, residence_type, and hospitalized that (I think...) we no longer ask for or send on the single entry side of things, is this something we also need to clean up/align with our bulk results upload? 🧐

@emyl3 Ooh these are great questions. We do send that data for all single-entry. IMO I think it's okay to send it and it won't hurt, but I don't know if I would categorize it as an HIV AOE question. However it's still valid data to be potentially included so maybe it does belong in the bulk upload guide somewhere? Another one potentially like that is patient sex assigned at birth.

Re: the fields that we only collect for bulk upload, I wouldn't mind if we stopped collecting them because from an engineering standpoint it makes maintenance either but I'm not sure whether we have product reasons for keeping them around.

cc @jayna-SkylightDigital to get her thoughts

mpbrown · 2024-10-11T18:21:38Z

Rebasing this PR for the new terraform changes, so I redeployed to dev6 and it's ready for re-review again!

sonarcloud · 2024-10-11T18:31:25Z

Quality Gate failed

Failed conditions
12.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

emyl3

🚢

mehansen

lgtm! thanks for this

mehansen · 2024-10-15T19:53:32Z

frontend/src/app/testResults/uploads/specificSchemaBuilder.ts

-export interface Item {
-  name: string;
-  colHeader: string;
-  required: boolean;
-  requested: boolean;
-  examples?: string[];
-  description?: string[];
-  acceptedValues?: string[];
-  format?: string;


nice consolidation

mpbrown temporarily deployed to dev6 October 3, 2024 16:38 — with GitHub Actions Inactive

mpbrown commented Oct 3, 2024

View reviewed changes

mpbrown marked this pull request as ready for review October 3, 2024 16:45

mpbrown requested review from mehansen, DanielSass, emyl3 and bobbywells52 October 3, 2024 16:46

mpbrown temporarily deployed to dev6 October 3, 2024 16:47 — with GitHub Actions Inactive

mpbrown temporarily deployed to dev6 October 3, 2024 16:51 — with GitHub Actions Inactive

mpbrown temporarily deployed to dev6 October 3, 2024 16:53 — with GitHub Actions Inactive

mpbrown temporarily deployed to dev6 October 3, 2024 17:03 — with GitHub Actions Inactive

mpbrown temporarily deployed to dev6 October 3, 2024 17:06 — with GitHub Actions Inactive

emyl3 reviewed Oct 4, 2024

View reviewed changes

frontend/src/app/testResults/uploads/CsvSchemaDocumentation.scss Show resolved Hide resolved

emyl3 reviewed Oct 4, 2024

View reviewed changes

mpbrown temporarily deployed to dev6 October 7, 2024 15:16 — with GitHub Actions Inactive

mpbrown temporarily deployed to dev6 October 7, 2024 15:57 — with GitHub Actions Inactive

mpbrown temporarily deployed to dev6 October 7, 2024 16:00 — with GitHub Actions Inactive

mpbrown requested a review from emyl3 October 7, 2024 16:57

emyl3 previously approved these changes Oct 7, 2024

View reviewed changes

bobbywells52 previously approved these changes Oct 8, 2024

View reviewed changes

mpbrown dismissed stale reviews from bobbywells52 and emyl3 via cfadc68 October 8, 2024 19:54

mpbrown requested review from emyl3 and bobbywells52 October 8, 2024 19:55

emyl3 approved these changes Oct 9, 2024

View reviewed changes

bobbywells52 approved these changes Oct 10, 2024

View reviewed changes

mpbrown added 15 commits October 11, 2024 14:19

Add tabs option for CSV doc sections

ae526f9

Change to using RequiredStatusTag

c483c4a

Add test for tab sections

3ff89fa

Add key to tab list items

275510f

Update tag table

d19b557

Remove requested

7afda1e

Update tab button

8e9b297

Fix tablist accessibility

017a728

Update snaphsot

08d4746

Replace concat

d737f3c

Refactor tab button into component

efaf353

Update snapshot

6806ae9

Zero left padding on first tab button

a3222ed

Add cursor style

dea91de

Remove other AOE columns for HIV

3e25037

mpbrown force-pushed the mike/7726-disease-labels-upload-guide branch from cfadc68 to 3e25037 Compare October 11, 2024 18:20

mpbrown temporarily deployed to dev6 October 11, 2024 18:20 — with GitHub Actions Inactive

mpbrown requested review from emyl3 and bobbywells52 October 11, 2024 18:21

mpbrown deployed to dev6 October 11, 2024 18:28 — with GitHub Actions View deployment

mpbrown deployed to dev6 October 11, 2024 18:31 — with GitHub Actions Active

emyl3 approved these changes Oct 11, 2024

View reviewed changes

mehansen approved these changes Oct 15, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add disease specific AOE tab for bulk upload guide #8165

Add disease specific AOE tab for bulk upload guide #8165

mpbrown commented Oct 1, 2024 •

edited

Loading

mpbrown Oct 3, 2024

emyl3 Oct 4, 2024

mpbrown Oct 7, 2024

emyl3 left a comment

emyl3 left a comment

mehansen commented Oct 8, 2024

bobbywells52 left a comment

mpbrown commented Oct 8, 2024

emyl3 commented Oct 9, 2024

emyl3 left a comment

mehansen commented Oct 10, 2024

mpbrown commented Oct 11, 2024

sonarcloud bot commented Oct 11, 2024

emyl3 left a comment

mehansen left a comment

mehansen Oct 15, 2024

Add disease specific AOE tab for bulk upload guide #8165

Are you sure you want to change the base?

Add disease specific AOE tab for bulk upload guide #8165

Conversation

mpbrown commented Oct 1, 2024 • edited Loading

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

Additional Information

Testing

Screenshots / Demos

mpbrown Oct 3, 2024

Choose a reason for hiding this comment

emyl3 Oct 4, 2024

Choose a reason for hiding this comment

mpbrown Oct 7, 2024

Choose a reason for hiding this comment

emyl3 left a comment

Choose a reason for hiding this comment

emyl3 left a comment

Choose a reason for hiding this comment

mehansen commented Oct 8, 2024

bobbywells52 left a comment

Choose a reason for hiding this comment

mpbrown commented Oct 8, 2024

emyl3 commented Oct 9, 2024

emyl3 left a comment

Choose a reason for hiding this comment

mehansen commented Oct 10, 2024

mpbrown commented Oct 11, 2024

sonarcloud bot commented Oct 11, 2024

Quality Gate failed

emyl3 left a comment

Choose a reason for hiding this comment

mehansen left a comment

Choose a reason for hiding this comment

mehansen Oct 15, 2024

Choose a reason for hiding this comment

mpbrown commented Oct 1, 2024 •

edited

Loading