How to Review and Test Pull Requests with Terraform Changes

How to review Pull Requests that include terraform changes.

• Select Details to the right of Terraform Checks / check-terraform-formatting (pull_request)

• Select terraform-plan on the left, then select Terraform Plan Prod to look at the resources that will be modified for the PR

• This is the key for Terraform actions, these symbols beside resources will explain the actions that will be applied once the terraform apply command is ran

• While reviewing the terraform plan, ensure the resources modified match the resources the PR owner identified in the PR Testing section

  • For example in the Testing Section of the PR, module.app_gateway.azurerm_application_gateway.load_balancer should be updated in place

• Search for the module in the logs and you will see this matches the PR testing section so this resources change has been verified

• If there is a resource modification that was not identified in the PR Testing section, annotate this in your PR comments so the owner can double check that this is not an unintentional change that was introduce with the code

How to test access to the app service:

1. go to the app service in Azure
2. click networking
3. Visit IP labeled Inbound Address, it should result in a 404.

Additionally, on the same networking page:

1. click the link for the Public network access which will take you to the Access Restrictions
2. Check that we only allow access from that environments load balancer.

How to smoke test the function app is:

dev3 was used for this smoke test

• Open up the simplereportdev3app storage account "Queues"

  • Have fhir-data-publishing and test-event-publishing queues open

• Go to https://dev3.simplereport.gov/app/queue and submit a single entry test with COVID and Flu result

• Check both queues to see there is a message in the expected format/shape. (Example of a message from a test submission):