Add category pointinterval plot to pipelines
#178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damonbayer
reviewed
Dec 4, 2024
There was a problem hiding this comment.
@dylanhmorris I think the categorization functions are better suited for CDCgov/forecasttools. What do you think?
If not, they should be placed in hewr so that I can reuse them in the forecast plots I am working on in https://github.com/CDCgov/pyrenew-hew/tree/dmb_enhance_forecast_fig
|
I agree but was planning to first put them here so we had the functionality for the pipeline and then move them in a separate PR |
damonbayer
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Approving without a deep review, since we plan to move much of this functionality to forecasttools. Created related issues: #181 CDCgov/forecasttools#29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #175