Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyrenew_hew_model sample signature for PyRenew-HE #265

Merged
merged 24 commits into from
Dec 30, 2024

Conversation

damonbayer
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 19.57%. Comparing base (74a2a3f) to head (1fa9da2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pyrenew_hew/pyrenew_hew_model.py 0.00% 11 Missing ⚠️
pipelines/build_pyrenew_model.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
- Coverage   19.64%   19.57%   -0.08%     
==========================================
  Files          20       20              
  Lines        1359     1364       +5     
==========================================
  Hits          267      267              
- Misses       1092     1097       +5     
Flag Coverage Δ
hewr 56.89% <ø> (ø)
pipelines 0.00% <0.00%> (ø)
pyrenew_hew 1.89% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damonbayer damonbayer marked this pull request as ready for review December 23, 2024 18:00
@damonbayer damonbayer changed the title (Draft) Update pyrenew_hew_model sample signature for PyRenew-HE Update pyrenew_hew_model sample signature for PyRenew-HE Dec 23, 2024
@damonbayer
Copy link
Collaborator Author

@dylanhmorris is this sufficient for your needs? There are many many places throughout the pipeline that eventually need to be changed to accommodate the new model, but this seems like a reasonable place to start that doesn't impact the pipeline.

@dylanhmorris dylanhmorris enabled auto-merge (squash) December 30, 2024 17:49
@dylanhmorris dylanhmorris merged commit d5c0199 into main Dec 30, 2024
13 of 15 checks passed
@dylanhmorris dylanhmorris deleted the dmb_pyrenw_he_signature branch December 30, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants