Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure for running on vintaged NSSP data #87

Merged
merged 21 commits into from
Oct 30, 2024

Conversation

dylanhmorris
Copy link
Contributor

Including the ability to mix facility-level recent vintages and earlier aggregate vintages, with checks to ensure data is deduplicated and also complete.

@damonbayer
Copy link
Collaborator

We should really think about file organization here or immediately after merging. Perhaps, put some of this in a "projects" folder, as suggested here #57 (comment)

nssp_demo/prep_data.py Outdated Show resolved Hide resolved
@dylanhmorris
Copy link
Contributor Author

We should really think about file organization here or immediately after merging. Perhaps, put some of this in a "projects" folder, as suggested here #57 (comment)

Agree, I think this is fairly high priority once this lands.

@dylanhmorris
Copy link
Contributor Author

Ready for re-review @damonbayer

nssp_demo/prep_data.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One provocative suggestion and a small string change, but I'm okay with merging.

@dylanhmorris dylanhmorris merged commit 2949f9f into main Oct 30, 2024
1 check passed
@dylanhmorris dylanhmorris deleted the dhm-historical-nssp branch October 30, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants