HikariCP config fix #1035
Merged
HikariCP config fix #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halprin
reviewed
Apr 23, 2024
| @@ -41,7 +43,8 @@ static HikariConfig constructHikariConfig() { | |||
| String serverName = ApplicationContext.getProperty("DB_URL", ""); | |||
| String dbName = ApplicationContext.getProperty("DB_NAME", ""); | |||
| String dbPort = ApplicationContext.getProperty("DB_PORT", ""); | |||
| String connectionLifetime = ApplicationContext.getProperty("DB_MAX_LIFETIME", "1800000"); | |||
| long connectionLifetime = | |||
| parseLong(ApplicationContext.getProperty("DB_MAX_LIFETIME", "1800000")); | |||
There was a problem hiding this comment.
Let's not static import a method from a class.
Suggested change
| parseLong(ApplicationContext.getProperty("DB_MAX_LIFETIME", "1800000")); | |
| Long.parseLong(ApplicationContext.getProperty("DB_MAX_LIFETIME", "1800000")); |
…Cgov/trusted-intermediary into story/1001/stg-db-connections
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
shared/src/main/java/gov/hhs/cdc/trustedintermediary/external/HikariConnectionPool.java
Fixed
Show resolved
Hide resolved
halprin
reviewed
Apr 23, 2024
Add catch for NumberFormatException Co-Authored-By: jherrflexion <[email protected]>
halprin
approved these changes
Apr 23, 2024
Refactoring DB_MAX_LIFETIME handling Co-Authored-By: Samuel Aquino <[email protected]>
Add more test cases Co-Authored-By: Samuel Aquino <[email protected]>
Fixed that and added some test coverage with @luis-pabon-tf |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a PR title
Fixes
maxLifetimesettings for HikariCP.Issue
Add a link to the issue here. Consider using
closing keywords
if the this PR isn't for a story (stories will be closed through different means).
Checklist
Note: You may remove items that are not applicable