Skip to content
This repository has been archived by the owner on Feb 7, 2025. It is now read-only.

Revisit 990 #1040

Merged
merged 17 commits into from
Apr 25, 2024
Merged

Revisit 990 #1040

merged 17 commits into from
Apr 25, 2024

Conversation

jorg3lopez
Copy link
Contributor

@jorg3lopez jorg3lopez commented Apr 24, 2024

Remove Sender and Receiver entities

This PR removes the sender and receiver columns from the database and from our code base. The sender and receiver can be access through the sendingFacilityDetails and the receivingFacilityDetails. Due to this, the isolated sender and receiver become redundant code.

The main work was to remove these entities from the PartnertMetadata class and from the database.

Issue

#990

Checklist

  • I have added tests to cover my changes

@jorg3lopez jorg3lopez marked this pull request as ready for review April 24, 2024 22:03
@jorg3lopez jorg3lopez marked this pull request as draft April 24, 2024 22:11
Copy link
Contributor

@basiliskus basiliskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments, otherwise looks good to me!

@jorg3lopez jorg3lopez marked this pull request as ready for review April 25, 2024 18:31
@jorg3lopez jorg3lopez requested a review from basiliskus April 25, 2024 18:32
Copy link
Member

@halprin halprin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it.

Copy link

@jorg3lopez jorg3lopez merged commit 373dae5 into main Apr 25, 2024
16 checks passed
@jorg3lopez jorg3lopez deleted the revisit-990 branch April 25, 2024 21:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants