Refactor CSG tracking with Reverse Polish Notation #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhamv
changed the title
|
You ran this on the nivida development system, right? |
Yes, I tested it on the mcdc-env you set up in the OSU ssh. But it would be great if you can double-check to be very sure. |
|
Everything passes! |
jpmorgan98
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSG tracking is refactored from a recursion of function calls into an algorithm based on the Reverse Polish Notation (Thanks, @braxtoncuneo, for the suggestions!). This fixes the GPU runtime error (#206) which turns out to be caused by the function recursions.