Merge the new tally structure #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decomposed mesh tallies when domain decomposition is active
|
I just noticed that I haven't checked if this PR is GPU-compatible. |
…into better_tally
…into better_tally
Adding 3D tally recomposition and 3D Domain Decomposition test
|
|
The GPU compatibility will be addressed in a separate PR (along with AMD interoperability). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch
better_tallywas created to facilitate several developments that build on top of the new tally structure.Merging the new tally structure into
dev,however, had to wait until a certain GPU mode issue (#206) was resolved. Now that the issue has been resolved (#222) let's merge thebetter_tallybranch intodev.cc: @alexandermote , @shac170, @ethan-lame