Validation fixes #47
Validation fixes #47
Conversation
The True is not needed with required
app/templates/check_email.html
Outdated
| @@ -53,7 +53,7 @@ <h5 class="card-title">{% trans %}Check configuration by sending an e-mail{% end | |||
| </div> | |||
| </div> | |||
|
|
|||
| <img class="spinner waiting" src="/static/images/spinner.svg" /> | |||
| <img class="spinner waiting" src="/static/images/spinner.svg" alt="spinner-waiting-img"/> | |||
There was a problem hiding this comment.
As 'alt' will be read by screen readers, would it be possible to add a human-readable message? E.g. "Waiting" - the Polish translation would be "Trwa oczekiwanie".
There was a problem hiding this comment.
Hi,
So far I can't seem to find a way to add a translation to an "alt" attribute without modifying the {{% trans % }} or making significant changes that would seem out of touch of your current translations and just changing the logic of the translations since I want to keep it the same way as it is. I will look further into this next week. We could just change the alt to "Waiting" and keep it like that as a general message without translation but ofcourse the translation would look prettier and more refined.
There was a problem hiding this comment.
I added something but please check whether the Lithuanian translation is OK, I don't know Lithuanian ;)
| @@ -46,6 +46,10 @@ msgstr "" | |||
| "Kad patikrinti el-pašto konfiguraciją, reikia išsiųsti bet kokį laišką " | |||
| "adresatui <b>nurodytam žemiau</b>:" | |||
|
|
|||
| #: app/templates/check_email.html:56 | |||
| msgid "Waiting" | |||
| msgstr "Laukimas" | |||
There was a problem hiding this comment.
@KarolisJasad is the Lithuanian translation OK?
|
@kazet Changed the translation of lithuanian language for "Waiting" and added the translation to check_running.html img alt aswell. |
html validation fixes