Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation fixes #47

Merged
merged 6 commits into from
Feb 21, 2024
Merged

Validation fixes #47

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
852d360
Validation fix
KarolisJasad Feb 15, 2024
533f4a6
Validation fixes
KarolisJasad Feb 15, 2024
d1fe4f2
translated
kazet Feb 21, 2024
18101f7
Translated alt name
KarolisJasad Feb 21, 2024
5af9226
Translation update
KarolisJasad Feb 21, 2024
6cceb67
.
kazet Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/templates/check_domain.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ <h5 class="card-title">{% trans %}Check domain{% endtrans %}</h5>
<form action="{{ url_for('check_domain_scan_post') }}" method="POST" class="card-text">
<div class="form-group">
<label for="domain-input">{% trans %}Domain{% endtrans %}</label>
<input name="domain" type="text" autocomplete="off" class="form-control" id="domain-input" aria-describedby="domain-info" required="true">
<input name="domain" type="text" autocomplete="off" class="form-control" id="domain-input" aria-describedby="domain-info" required>
<small id="domain-info" class="form-text text-muted">
{% trans %}Don't put the entire e-mail address here, only the part after "@"{% endtrans %}
</small>
Expand Down
4 changes: 2 additions & 2 deletions app/templates/check_email.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
<div class="card-body">
<h5 class="card-title">{% trans %}Check configuration by sending an e-mail{% endtrans %}</h5>
<div class="card-text">
<label for="email-input">
<label for="email">
{{ _("To verify e-mail configuration, send any e-mail message to the address <b>shown below</b>:")|safe }}
</label>
<div class="mailto-link-with-button">
Expand All @@ -53,7 +53,7 @@ <h5 class="card-title">{% trans %}Check configuration by sending an e-mail{% end
</div>
</div>

<img class="spinner waiting" src="/static/images/spinner.svg" />
<img class="spinner waiting" src="/static/images/spinner.svg" alt="spinner-waiting-img"/>
Copy link
Member

@kazet kazet Feb 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As 'alt' will be read by screen readers, would it be possible to add a human-readable message? E.g. "Waiting" - the Polish translation would be "Trwa oczekiwanie".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
So far I can't seem to find a way to add a translation to an "alt" attribute without modifying the {{% trans % }} or making significant changes that would seem out of touch of your current translations and just changing the logic of the translations since I want to keep it the same way as it is. I will look further into this next week. We could just change the alt to "Waiting" and keep it like that as a general message without translation but ofcourse the translation would look prettier and more refined.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added something but please check whether the Lithuanian translation is OK, I don't know Lithuanian ;)

<h5 class="waiting">{% trans %}Waiting for the message to be received{% endtrans %}</h5>

<p>
Expand Down
Loading