-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix initialisation issues in Mesh_3 #7552
Conversation
Runtime errors in CGAL-6.0-Ic-13 in Generator package (at least)
|
@janetournois @lrineau That's actually the configuration that we were discussing: the source of the ray being shot in the C3T3 initialization is a point exactly on the domain. Beforehand, it would find another intersection; now, source of the ray is returned whatever the ray direction, and the initialization only spawns a single point. |
…eight The code break'd but did not restart if a special ball was encountered
This comment was marked as outdated.
This comment was marked as outdated.
7002332
to
0d34585
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This is a band aid fix, a proper fix is to rework the full initilization pipeline. This is the purpose of the following pull request: CGAL#7606
3980665
to
1f258bc
Compare
This PR should be finished now. Other issues are related to edge protection and will be handled in a different pull request. |
Fix initialisation issues in Mesh_3
Fix initialisation issues in Mesh_3
Fix initialisation issues in Mesh_3
This PR was merged into 5.5.x-branch (too late for 5.5.3 though). |
Summary of Changes
init_c3t3()
could not insert initial points.Release Management