Mesh_3 - edge_min_size may cause hanging
#7863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is set when minimal_size is set, the graph of features is likely to be invalid or at least inconsistent with the input graph so checking its topology does not make any sense and could lead to - assertions failing in debug mode, - hanging in release mode
|
lrineau
added
the
Not yet approved
this warning was caused by another PR (that has been merged since then) |
|
@lrineau you added "not yet approved" before Jane's answer. Is that still the case? |
sloriot
added
Under Testing
Tests failing
and removed
Not yet approved
|
disabling it may give too bad results change the arc_length computation when minimal size is used, instead, by approximating it by the segment length
Yes, I would like to discuss that with Jane. |
lrineau
added
the
Not yet approved
lrineau
approved these changes
Dec 21, 2023
lrineau
removed
the
Not yet approved
It is done. The PR is ready to be tested. |
|
Successfully tested in CGAL-6.0-Ic-134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
When the criterion
edge_min_sizeis set, the graph of features is likely to be invalid or at least inconsistent with the input graph.Checking its topology does not make any sense and could lead to hanging when trying to compute polyline feature lengths (because it's trying to walk on different curves, jumping from one to the other, etc).
This PR disables the check-features-after-protect step when
edge_min_sizeis used, since we anyway do not expect the feature graph to be exactly matching the one of the input.Release Management