Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh_3 - edge_min_size may cause hanging #7863

Merged
merged 6 commits into from
Dec 22, 2023
Merged

Mesh_3 - edge_min_size may cause hanging #7863

merged 6 commits into from
Dec 22, 2023

Commits on Nov 14, 2023

  1. do not check the graph of features after protection when minimal_size… 

    … is set

when minimal_size is set, the graph of features is likely to be invalid

or at least inconsistent with the input graph
so checking its topology does not make any sense and could lead to
- assertions failing in debug mode,
- hanging in release mode
    @janetournois
    janetournois committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    e4e13e2 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. set default minimal_size_ to -1 and add helper function to check if i… 

    …t is set
    @janetournois
    janetournois committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    54677b3 View commit details
    Browse the repository at this point in the history

  2. constify more

    @janetournois
    janetournois committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    85b8da1 View commit details
    Browse the repository at this point in the history

  3. add helper function minimal_weight()

    @janetournois
    janetournois committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    7fa2db8 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. check_and_repopulate_edges() reactivated with minimal size 

    disabling it may give too bad results
change the arc_length computation when minimal size is used, instead,
by approximating it by the segment length
    @janetournois
    janetournois committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    3ef2ce9 View commit details
    Browse the repository at this point in the history

  2. when curves topology is valid, use curve_segment_length

    @janetournois
    janetournois committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    a66e78a View commit details
    Browse the repository at this point in the history