Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CGAL: Modernize CMakeLists.txt #8528

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

CGAL: Modernize CMakeLists.txt #8528

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
5275693
CGAL: Modernize CMakeLists.txt
afabri Oct 8, 2024
63928f5
Eigen_support -> Eigen3_support (concerns kinetic @soesau)
afabri Oct 8, 2024
eaa2dfc
Eigen_support -> Eigen3_support (concerns kinetic @soesau)
afabri Oct 8, 2024
59903f1
I guess this was before inherited from one of the item classes @lrineau
afabri Oct 8, 2024
ad8ece6
more plugins depend on Eigen
afabri Oct 8, 2024
520a1af
Can we savely remove add_definitions(-DQT_NO_KEYWORDS) @lrineau ?
afabri Oct 9, 2024
9561615
More PRIVATE in LCC and Generalized_map
afabri Oct 9, 2024
74e8e23
Use target_compile_definitions()
afabri Oct 9, 2024
d817dda
Use target_compile_definitions()
afabri Oct 9, 2024
10b3705
Only link to Boost::program_options and not to Do the same later …
afabri Oct 9, 2024
9e75ab3
Use add_compile_definitions
afabri Oct 9, 2024
5829760
No need to include from ../../include
afabri Oct 9, 2024
9bf4134
Only link with Boost::program_options - Supported the minimum require…
afabri Oct 9, 2024
63d2a26
Use Boost::serialization and Boost::iostreams
afabri Oct 9, 2024
4bde1e6
missing )
afabri Oct 10, 2024
ec895d6
Simplified CMakeLists of Point_set_processing @soesau please check
afabri Oct 10, 2024
9edf6ea
Cleanup in Shape_detection
afabri Oct 10, 2024
2ca1c4e
first batch of modifications during my review
lrineau Oct 14, 2024
c0b59bd
second batch of modifications after review
lrineau Oct 16, 2024
d759e72
third batch of modifications
lrineau Oct 16, 2024
96cd3e6
Merge remote-tracking branch 'cgal/master' into pr/afabri/8528
lrineau Oct 16, 2024
d7dc57f
Merge remote-tracking branch 'cgal/master' into pr/afabri/8528
lrineau Oct 16, 2024
a0d79b7
fix the documentation
lrineau Oct 16, 2024
439df74
leftovers I had not pointed out
lrineau Oct 17, 2024
868e351
fixes
lrineau Oct 21, 2024
fb2a9ea
Merge remote-tracking branch 'cgal/master' into pr/afabri/8528
lrineau Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions Arrangement_on_surface_2/examples/Arrangement_on_surface_2/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ foreach(cppfile ${cppfiles})
endforeach()

if(CGAL_Qt6_FOUND)
target_link_libraries(draw_arr PUBLIC CGAL::CGAL_Basic_viewer)
target_link_libraries(linear_conics PUBLIC CGAL::CGAL_Basic_viewer)
target_link_libraries(parabolas PUBLIC CGAL::CGAL_Basic_viewer)
target_link_libraries(ellipses PUBLIC CGAL::CGAL_Basic_viewer)
target_link_libraries(hyperbolas PUBLIC CGAL::CGAL_Basic_viewer)
target_link_libraries(polylines PUBLIC CGAL::CGAL_Basic_viewer)
target_link_libraries(circles PUBLIC CGAL::CGAL_Basic_viewer)
target_link_libraries(circular_arcs PUBLIC CGAL::CGAL_Basic_viewer)
target_link_libraries(spherical_insert PUBLIC CGAL::CGAL_Basic_viewer)
target_link_libraries(draw_arr PRIVATE CGAL::CGAL_Basic_viewer)
target_link_libraries(linear_conics PRIVATE CGAL::CGAL_Basic_viewer)
target_link_libraries(parabolas PRIVATE CGAL::CGAL_Basic_viewer)
target_link_libraries(ellipses PRIVATE CGAL::CGAL_Basic_viewer)
target_link_libraries(hyperbolas PRIVATE CGAL::CGAL_Basic_viewer)
target_link_libraries(polylines PRIVATE CGAL::CGAL_Basic_viewer)
target_link_libraries(circles PRIVATE CGAL::CGAL_Basic_viewer)
target_link_libraries(circular_arcs PRIVATE CGAL::CGAL_Basic_viewer)
target_link_libraries(spherical_insert PRIVATE CGAL::CGAL_Basic_viewer)
else()
message(
STATUS
Expand Down
2 changes: 1 addition & 1 deletion BGL/examples/BGL_polyhedron_3/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ find_package(METIS QUIET)
include(CGAL_METIS_support)
if(TARGET CGAL::METIS_support)
create_single_source_cgal_program("polyhedron_partition.cpp")
target_link_libraries(polyhedron_partition PUBLIC CGAL::METIS_support)
target_link_libraries(polyhedron_partition PRIVATE CGAL::METIS_support)
else()
message(STATUS "NOTICE: The example 'polyhedron_partition' requires the METIS library, and will not be compiled.")
endif()
2 changes: 1 addition & 1 deletion BGL/examples/BGL_surface_mesh/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ find_package(METIS QUIET)
include(CGAL_METIS_support)
if(TARGET CGAL::METIS_support)
create_single_source_cgal_program("surface_mesh_partition.cpp")
target_link_libraries(surface_mesh_partition PUBLIC CGAL::METIS_support)
target_link_libraries(surface_mesh_partition PRIVATE CGAL::METIS_support)
else()
message(STATUS "NOTICE: Examples that use the METIS library will not be compiled.")
endif()
4 changes: 2 additions & 2 deletions Barycentric_coordinates_2/benchmark/Barycentric_coordinates_2/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ find_package(Eigen3 3.1.0 QUIET) # (3.1.0 or greater)
include(CGAL_Eigen3_support)
if(TARGET CGAL::Eigen3_support)
create_single_source_cgal_program("benchmark_hm_4_vertices.cpp")
target_link_libraries(benchmark_hm_4_vertices PUBLIC CGAL::Eigen3_support)
target_link_libraries(benchmark_hm_4_vertices PRIVATE CGAL::Eigen3_support)
create_single_source_cgal_program("benchmark_hm_n_vertices.cpp")
target_link_libraries(benchmark_hm_n_vertices PUBLIC CGAL::Eigen3_support)
target_link_libraries(benchmark_hm_n_vertices PRIVATE CGAL::Eigen3_support)
else()
message(STATUS "NOTICE: Several benchmarks require the Eigen library, and will not be compiled.")
endif()
6 changes: 3 additions & 3 deletions Barycentric_coordinates_2/examples/Barycentric_coordinates_2/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ find_package(Eigen3 3.1.0 QUIET) # (3.1.0 or greater)
include(CGAL_Eigen3_support)
if(TARGET CGAL::Eigen3_support)
create_single_source_cgal_program("affine_coordinates.cpp")
target_link_libraries(affine_coordinates PUBLIC CGAL::Eigen3_support)
target_link_libraries(affine_coordinates PRIVATE CGAL::Eigen3_support)
create_single_source_cgal_program("harmonic_coordinates.cpp")
target_link_libraries(harmonic_coordinates PUBLIC CGAL::Eigen3_support)
target_link_libraries(harmonic_coordinates PRIVATE CGAL::Eigen3_support)
create_single_source_cgal_program("shape_deformation.cpp")
target_link_libraries(shape_deformation PUBLIC CGAL::Eigen3_support)
target_link_libraries(shape_deformation PRIVATE CGAL::Eigen3_support)
else()
message(STATUS "NOTICE: Several examples require the Eigen library, and will not be compiled.")
endif()
10 changes: 5 additions & 5 deletions Barycentric_coordinates_2/test/Barycentric_coordinates_2/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,15 @@ find_package(Eigen3 3.1.0 QUIET) # (3.1.0 or greater)
include(CGAL_Eigen3_support)
if(TARGET CGAL::Eigen3_support)
create_single_source_cgal_program("test_hm_unit_square.cpp")
target_link_libraries(test_hm_unit_square PUBLIC CGAL::Eigen3_support)
target_link_libraries(test_hm_unit_square PRIVATE CGAL::Eigen3_support)
create_single_source_cgal_program("test_hm_const_linear_precision.cpp")
target_link_libraries(test_hm_const_linear_precision PUBLIC CGAL::Eigen3_support)
target_link_libraries(test_hm_const_linear_precision PRIVATE CGAL::Eigen3_support)
create_single_source_cgal_program("test_hm_triangle.cpp")
target_link_libraries(test_hm_triangle PUBLIC CGAL::Eigen3_support)
target_link_libraries(test_hm_triangle PRIVATE CGAL::Eigen3_support)
create_single_source_cgal_program("test_bc_projection_traits.cpp")
target_link_libraries(test_bc_projection_traits PUBLIC CGAL::Eigen3_support)
target_link_libraries(test_bc_projection_traits PRIVATE CGAL::Eigen3_support)
create_single_source_cgal_program("test_bc_all_coordinates.cpp")
target_link_libraries(test_bc_all_coordinates PUBLIC CGAL::Eigen3_support)
target_link_libraries(test_bc_all_coordinates PRIVATE CGAL::Eigen3_support)
else()
message(STATUS "NOTICE: Several tests require the Eigen library, and will not be compiled.")
endif()
16 changes: 8 additions & 8 deletions Basic_viewer/examples/Basic_viewer/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,19 @@ create_single_source_cgal_program("draw_surface_mesh_vcolor.cpp")

if(CGAL_Qt6_FOUND)
#link it with the required CGAL libraries
target_link_libraries(draw_lcc PUBLIC CGAL::CGAL_Basic_viewer)
target_link_libraries(draw_mesh_and_points PUBLIC CGAL::CGAL_Basic_viewer)
target_link_libraries(draw_several_windows PUBLIC CGAL::CGAL_Basic_viewer)
target_link_libraries(draw_surface_mesh_height PUBLIC CGAL::CGAL_Basic_viewer)
target_link_libraries(draw_surface_mesh_small_faces PUBLIC CGAL::CGAL_Basic_viewer)
target_link_libraries(draw_surface_mesh_vcolor PUBLIC CGAL::CGAL_Basic_viewer)
target_link_libraries(draw_lcc PRIVATE CGAL::CGAL_Basic_viewer)
target_link_libraries(draw_mesh_and_points PRIVATE CGAL::CGAL_Basic_viewer)
target_link_libraries(draw_several_windows PRIVATE CGAL::CGAL_Basic_viewer)
target_link_libraries(draw_surface_mesh_height PRIVATE CGAL::CGAL_Basic_viewer)
target_link_libraries(draw_surface_mesh_small_faces PRIVATE CGAL::CGAL_Basic_viewer)
target_link_libraries(draw_surface_mesh_vcolor PRIVATE CGAL::CGAL_Basic_viewer)
else()
message("CGAL_Qt6 not configured: examples that require Qt will not be compiled.")
endif()

if(TARGET CGAL::Eigen3_support)
target_link_libraries(draw_mesh_and_points PUBLIC CGAL::Eigen3_support)
target_link_libraries(draw_several_windows PUBLIC CGAL::Eigen3_support)
target_link_libraries(draw_mesh_and_points PRIVATE CGAL::Eigen3_support)
target_link_libraries(draw_several_windows PRIVATE CGAL::Eigen3_support)
endif()

#end of the file
2 changes: 1 addition & 1 deletion Boolean_set_operations_2/examples/Boolean_set_operations_2/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ foreach(cppfile ${cppfiles})
endforeach()

if(CGAL_Qt6_FOUND)
target_link_libraries(draw_polygon_set PUBLIC CGAL::CGAL_Basic_viewer)
target_link_libraries(draw_polygon_set PRIVATE CGAL::CGAL_Basic_viewer)
else()
message(STATUS "NOTICE: The example 'draw_polygon_set' requires Qt and drawing will be disabled.")
endif()
2 changes: 1 addition & 1 deletion Box_intersection_d/test/Box_intersection_d/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ create_single_source_cgal_program("test_Has_member_report.cpp")
find_package(TBB QUIET)
include(CGAL_TBB_support)
if(TARGET CGAL::TBB_support)
target_link_libraries(test_box_grid PUBLIC CGAL::TBB_support)
target_link_libraries(test_box_grid PRIVATE CGAL::TBB_support)
else()
message(STATUS "NOTICE: Intel TBB was not found. Parallel code will not be used.")
endif()
6 changes: 3 additions & 3 deletions Classification/examples/Classification/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ if(TARGET CGAL::OpenCV_support)
message(STATUS "Found OpenCV")

create_single_source_cgal_program( "example_opencv_random_forest.cpp" )
target_link_libraries(example_opencv_random_forest PUBLIC CGAL::OpenCV_support)
target_link_libraries(example_opencv_random_forest PRIVATE CGAL::OpenCV_support)
else()
message("NOTICE: OpenCV was not found. OpenCV random forest predicate for classification won't be available.")
endif()
Expand All @@ -68,11 +68,11 @@ foreach(target
gis_tutorial_example
example_deprecated_conversion)
if(TARGET ${target})
target_link_libraries(${target} PUBLIC CGAL::Eigen3_support
target_link_libraries(${target} PRIVATE CGAL::Eigen3_support
CGAL::Boost_iostreams_support
CGAL::Boost_serialization_support)
if(TARGET CGAL::TBB_support)
target_link_libraries(${target} PUBLIC CGAL::TBB_support)
target_link_libraries(${target} PRIVATE CGAL::TBB_support)
endif()
endif()
endforeach()
4 changes: 2 additions & 2 deletions Classification/test/Classification/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ create_single_source_cgal_program("test_classification_point_set.cpp")
create_single_source_cgal_program("test_classification_io.cpp")

foreach(target test_classification_point_set test_classification_io)
target_link_libraries(${target} PUBLIC CGAL::Eigen3_support
target_link_libraries(${target} PRIVATE CGAL::Eigen3_support
CGAL::Boost_iostreams_support
CGAL::Boost_serialization_support)
if(TARGET CGAL::TBB_support)
target_link_libraries(${target} PUBLIC CGAL::TBB_support)
target_link_libraries(${target} PRIVATE CGAL::TBB_support)
endif()
endforeach()
8 changes: 4 additions & 4 deletions Heat_method_3/examples/Heat_method_3/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ endif()
include_directories(BEFORE include)

create_single_source_cgal_program("heat_method.cpp")
target_link_libraries(heat_method PUBLIC CGAL::Eigen3_support)
target_link_libraries(heat_method PRIVATE CGAL::Eigen3_support)
create_single_source_cgal_program("heat_method_polyhedron.cpp")
target_link_libraries(heat_method_polyhedron PUBLIC CGAL::Eigen3_support)
target_link_libraries(heat_method_polyhedron PRIVATE CGAL::Eigen3_support)
create_single_source_cgal_program("heat_method_surface_mesh.cpp")
target_link_libraries(heat_method_surface_mesh PUBLIC CGAL::Eigen3_support)
target_link_libraries(heat_method_surface_mesh PRIVATE CGAL::Eigen3_support)
create_single_source_cgal_program("heat_method_surface_mesh_direct.cpp")
target_link_libraries(heat_method_surface_mesh_direct PUBLIC CGAL::Eigen3_support)
target_link_libraries(heat_method_surface_mesh_direct PRIVATE CGAL::Eigen3_support)
8 changes: 4 additions & 4 deletions Heat_method_3/test/Heat_method_3/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ endif()
include_directories(BEFORE include)

create_single_source_cgal_program("heat_method_concept.cpp")
target_link_libraries(heat_method_concept PUBLIC CGAL::Eigen3_support)
target_link_libraries(heat_method_concept PRIVATE CGAL::Eigen3_support)
create_single_source_cgal_program("heat_method_surface_mesh_test.cpp")
target_link_libraries(heat_method_surface_mesh_test PUBLIC CGAL::Eigen3_support)
target_link_libraries(heat_method_surface_mesh_test PRIVATE CGAL::Eigen3_support)
create_single_source_cgal_program("heat_method_surface_mesh_direct_test.cpp")
target_link_libraries(heat_method_surface_mesh_direct_test PUBLIC CGAL::Eigen3_support)
target_link_libraries(heat_method_surface_mesh_direct_test PRIVATE CGAL::Eigen3_support)
create_single_source_cgal_program("heat_method_surface_mesh_intrinsic_test.cpp")
target_link_libraries(heat_method_surface_mesh_intrinsic_test PUBLIC CGAL::Eigen3_support)
target_link_libraries(heat_method_surface_mesh_intrinsic_test PRIVATE CGAL::Eigen3_support)
2 changes: 1 addition & 1 deletion Installation/test/Installation/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ find_package(TBB QUIET)
include(CGAL_TBB_support)
create_single_source_cgal_program("test_TBB.cpp")
if(TARGET CGAL::TBB_support)
target_link_libraries(test_TBB PUBLIC CGAL::TBB_support)
target_link_libraries(test_TBB PRIVATE CGAL::TBB_support)
endif()

create_link_to_program(CGAL)
Expand Down
4 changes: 2 additions & 2 deletions Jet_fitting_3/examples/Jet_fitting_3/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ if(TARGET CGAL::Eigen3_support)
find_package(Boost QUIET COMPONENTS program_options)
if(Boost_PROGRAM_OPTIONS_FOUND)
create_single_source_cgal_program("Mesh_estimation.cpp")
target_link_libraries(Mesh_estimation PUBLIC CGAL::Eigen3_support)
target_link_libraries(Mesh_estimation PRIVATE CGAL::Eigen3_support)
if(TARGET Boost::program_options)
target_link_libraries(Mesh_estimation PRIVATE Boost::program_options)
else()
Expand All @@ -26,7 +26,7 @@ if(TARGET CGAL::Eigen3_support)
endif()

create_single_source_cgal_program("Single_estimation.cpp")
target_link_libraries(Single_estimation PUBLIC CGAL::Eigen3_support)
target_link_libraries(Single_estimation PRIVATE CGAL::Eigen3_support)

else()
message("NOTICE: These examples require Eigen 3.1 (or greater), and will not be compiled.")
Expand Down
2 changes: 1 addition & 1 deletion Jet_fitting_3/test/Jet_fitting_3/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ find_package(Eigen3 3.1.0 QUIET) #(requires 3.1.0 or greater)
include(CGAL_Eigen3_support)
if(TARGET CGAL::Eigen3_support)
create_single_source_cgal_program("blind_1pt.cpp")
target_link_libraries(blind_1pt PUBLIC CGAL::Eigen3_support)
target_link_libraries(blind_1pt PRIVATE CGAL::Eigen3_support)
else()
message("NOTICE: This project requires Eigen 3.1 (or greater), and will not be compiled.")
endif()
4 changes: 2 additions & 2 deletions Kinetic_space_partition/examples/Kinetic_space_partition/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ include(CGAL_CreateSingleSourceCGALProgram)
find_package(Eigen3 3.1.0 REQUIRED)
if(Eigen3_FOUND)
message(STATUS "Found Eigen")
include(CGAL_Eigen_support)
include(CGAL_Eigen3_support)

set(targets kinetic_partition)

foreach(target ${targets})
create_single_source_cgal_program("${target}.cpp")
target_link_libraries(${target} PUBLIC CGAL::Eigen_support)
target_link_libraries(${target} PRIVATE CGAL::Eigen3_support)
endforeach()
else()
message(ERROR "This program requires the Eigen library, and will not be compiled.")
Expand Down
4 changes: 2 additions & 2 deletions Kinetic_space_partition/test/Kinetic_space_partition/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ if(Boost_FOUND)
find_package(Eigen3 3.1.0 REQUIRED)
if(Eigen3_FOUND)
message(STATUS "Found Eigen")
include(CGAL_Eigen_support)
include(CGAL_Eigen3_support)

set(targets kinetic_3d_test_all)

Expand All @@ -27,7 +27,7 @@ if(Boost_FOUND)
foreach(target ${targets})
create_single_source_cgal_program("${target}.cpp")
if(TARGET ${target})
target_link_libraries(${target} PUBLIC ${project_linked_libraries} CGAL::Eigen_support)
target_link_libraries(${target} PUBLIC ${project_linked_libraries} CGAL::Eigen3_support)
target_compile_definitions(${target} PUBLIC ${project_compilation_definitions})
endif()
endforeach()
Expand Down
4 changes: 2 additions & 2 deletions Kinetic_surface_reconstruction/examples/Kinetic_surface_reconstruction/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ include(CGAL_CreateSingleSourceCGALProgram)
find_package(Eigen3 3.1.0 REQUIRED)
if(Eigen3_FOUND)
message(STATUS "Found Eigen")
include(CGAL_Eigen_support)
include(CGAL_Eigen3_support)

set(targets ksr_basic ksr_building ksr_parameters)

foreach(target ${targets})
create_single_source_cgal_program("${target}.cpp")
target_link_libraries(${target} PUBLIC CGAL::Eigen_support)
target_link_libraries(${target} PRIVATE CGAL::Eigen3_support)
endforeach()
else()
message(ERROR "This program requires the Eigen library, and will not be compiled.")
Expand Down
4 changes: 2 additions & 2 deletions Kinetic_surface_reconstruction/test/Kinetic_surface_reconstruction/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ include(CGAL_CreateSingleSourceCGALProgram)
find_package(Eigen3 3.1.0 REQUIRED)
if(Eigen3_FOUND)
message(STATUS "Found Eigen")
include(CGAL_Eigen_support)
include(CGAL_Eigen3_support)

set(targets ksr_test ksr_reorientation ksr_regularization)

foreach(target ${targets})
create_single_source_cgal_program("${target}.cpp")
target_link_libraries(${target} PUBLIC CGAL::Eigen_support)
target_link_libraries(${target} PRIVATE CGAL::Eigen3_support)
endforeach()
else()
message(ERROR "This program requires the Eigen library, and will not be compiled.")
Expand Down
18 changes: 9 additions & 9 deletions Lab/demo/Lab/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,8 +250,8 @@ if(CGAL_Qt6_FOUND AND Qt6_FOUND)
scene_basic_objects ${TBB_LIBRARIES})

if(TARGET CGAL::TBB_support)
target_link_libraries(scene_c3t3_item PUBLIC CGAL::TBB_support)
target_link_libraries(scene_triangulation_3_item PUBLIC CGAL::TBB_support)
target_link_libraries(scene_c3t3_item PRIVATE CGAL::TBB_support)
target_link_libraries(scene_triangulation_3_item PRIVATE CGAL::TBB_support)
endif()
if(COMMAND target_precompile_headers)
# Support for precompiled headers, for Mesh_3 (since CMake 3.16)
Expand All @@ -278,7 +278,7 @@ if(CGAL_Qt6_FOUND AND Qt6_FOUND)
add_item(scene_surface_mesh_item Scene_surface_mesh_item.cpp)

if(TBB_FOUND)
target_link_libraries(scene_surface_mesh_item PUBLIC CGAL::TBB_support)
target_link_libraries(scene_surface_mesh_item PRIVATE CGAL::TBB_support)
endif()
# special

Expand All @@ -293,7 +293,7 @@ if(CGAL_Qt6_FOUND AND Qt6_FOUND)
target_link_libraries(scene_selection_item PUBLIC scene_item_decorator
scene_k_ring_selection)
if(TBB_FOUND)
target_link_libraries(scene_selection_item PUBLIC CGAL::TBB_support)
target_link_libraries(scene_selection_item PRIVATE CGAL::TBB_support)
endif()

add_item(scene_shortest_path_item
Expand All @@ -307,9 +307,9 @@ if(CGAL_Qt6_FOUND AND Qt6_FOUND)
if(TARGET CGAL::Eigen3_support)
add_item(scene_textured_item Scene_textured_surface_mesh_item.cpp
texture.cpp)
target_link_libraries(scene_textured_item PUBLIC CGAL::Eigen3_support)
target_link_libraries(scene_textured_item PRIVATE CGAL::Eigen3_support)
add_item(scene_mcf_item Plugins/PMP/Scene_mcf_item.cpp)
target_link_libraries(scene_mcf_item PUBLIC CGAL::Eigen3_support)
target_link_libraries(scene_mcf_item PRIVATE CGAL::Eigen3_support)
endif()

add_item(scene_implicit_function_item Scene_implicit_function_item.cpp)
Expand All @@ -325,12 +325,12 @@ if(CGAL_Qt6_FOUND AND Qt6_FOUND)
add_item(scene_points_with_normal_item Scene_points_with_normal_item.cpp)
if(TARGET CGAL::Eigen3_support)
target_link_libraries(scene_points_with_normal_item
PUBLIC CGAL::Eigen3_support)
PRIVATE CGAL::Eigen3_support)
endif()

if(TBB_FOUND)
target_link_libraries(scene_points_with_normal_item
PUBLIC CGAL::TBB_support)
PRIVATE CGAL::TBB_support)
endif()

add_item(scene_polylines_item Scene_polylines_item.cpp)
Expand Down Expand Up @@ -381,7 +381,7 @@ if(CGAL_Qt6_FOUND AND Qt6_FOUND)
target_link_libraries(CGALlab PRIVATE demo_framework)

# Link with CGAL
target_link_libraries(CGALlab PUBLIC CGAL::CGAL_Qt6)
target_link_libraries(CGALlab PRIVATE CGAL::CGAL_Qt6)

add_to_cached_list(CGAL_EXECUTABLE_TARGETS CGALlab)

Expand Down
2 changes: 1 addition & 1 deletion Lab/demo/Lab/Plugins/AABB_tree/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ cgal_lab_plugin(cut_plugin Cut_plugin)
target_link_libraries(cut_plugin PUBLIC scene_surface_mesh_item
scene_basic_objects scene_color_ramp)
if(TARGET CGAL::TBB_support)
target_link_libraries(cut_plugin PUBLIC CGAL::TBB_support)
target_link_libraries(cut_plugin PRIVATE CGAL::TBB_support)
endif()
6 changes: 3 additions & 3 deletions Lab/demo/Lab/Plugins/Classification/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,16 @@ if(TARGET CGAL::Eigen3_support)
endif()

if(TARGET CGAL::Boost_serialization_support AND TARGET CGAL::Boost_iostreams_support)
target_link_libraries(classification_plugin PUBLIC CGAL::Boost_serialization_support
target_link_libraries(classification_plugin PRIVATE CGAL::Boost_serialization_support
CGAL::Boost_iostreams_support)
endif()

if(TARGET CGAL::OpenCV_support)
target_link_libraries(classification_plugin PUBLIC CGAL::OpenCV_support)
target_link_libraries(classification_plugin PRIVATE CGAL::OpenCV_support)
endif()

if(TARGET CGAL::TBB_support)
target_link_libraries(classification_plugin PUBLIC CGAL::TBB_support)
target_link_libraries(classification_plugin PRIVATE CGAL::TBB_support)
endif()

add_dependencies(classification_plugin point_set_selection_plugin selection_plugin)
Expand Down
Loading