Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CGAL: Modernize CMakeLists.txt #8528

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
+716 −812
Open

CGAL: Modernize CMakeLists.txt #8528

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
5275693
CGAL: Modernize CMakeLists.txt
afabri Oct 8, 2024
63928f5
Eigen_support -> Eigen3_support (concerns kinetic @soesau)
afabri Oct 8, 2024
eaa2dfc
Eigen_support -> Eigen3_support (concerns kinetic @soesau)
afabri Oct 8, 2024
59903f1
I guess this was before inherited from one of the item classes @lrineau
afabri Oct 8, 2024
ad8ece6
more plugins depend on Eigen
afabri Oct 8, 2024
520a1af
Can we savely remove add_definitions(-DQT_NO_KEYWORDS) @lrineau ?
afabri Oct 9, 2024
9561615
More PRIVATE in LCC and Generalized_map
afabri Oct 9, 2024
74e8e23
Use target_compile_definitions()
afabri Oct 9, 2024
d817dda
Use target_compile_definitions()
afabri Oct 9, 2024
10b3705
Only link to Boost::program_options and not to Do the same later …
afabri Oct 9, 2024
9e75ab3
Use add_compile_definitions
afabri Oct 9, 2024
5829760
No need to include from ../../include
afabri Oct 9, 2024
9bf4134
Only link with Boost::program_options - Supported the minimum require…
afabri Oct 9, 2024
63d2a26
Use Boost::serialization and Boost::iostreams
afabri Oct 9, 2024
4bde1e6
missing )
afabri Oct 10, 2024
ec895d6
Simplified CMakeLists of Point_set_processing @soesau please check
afabri Oct 10, 2024
9edf6ea
Cleanup in Shape_detection
afabri Oct 10, 2024
2ca1c4e
first batch of modifications during my review
lrineau Oct 14, 2024
c0b59bd
second batch of modifications after review
lrineau Oct 16, 2024
d759e72
third batch of modifications
lrineau Oct 16, 2024
96cd3e6
Merge remote-tracking branch 'cgal/master' into pr/afabri/8528
lrineau Oct 16, 2024
d7dc57f
Merge remote-tracking branch 'cgal/master' into pr/afabri/8528
lrineau Oct 16, 2024
a0d79b7
fix the documentation
lrineau Oct 16, 2024
439df74
leftovers I had not pointed out
lrineau Oct 17, 2024
868e351
fixes
lrineau Oct 21, 2024
fb2a9ea
Merge remote-tracking branch 'cgal/master' into pr/afabri/8528
lrineau Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lab/demo/Lab/Plugins/PCA/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ cgal_lab_plugin(create_obb_mesh_plugin Create_obb_mesh_plugin)
target_link_libraries(create_obb_mesh_plugin PUBLIC scene_surface_mesh_item
scene_polygon_soup_item
scene_selection_item
scene_points_with_normal_item)
scene_points_with_normal_item CGAL::Eigen3_support)
lrineau marked this conversation as resolved.
Show resolved Hide resolved

qt6_wrap_ui(volumesUI_FILES Basic_generator_widget.ui)
cgal_lab_plugin(
Expand Down