Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connected back end isResolved with front end isResolved placeholder button #75

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

LujainAlMansoori
Copy link
Contributor

@LujainAlMansoori LujainAlMansoori commented Sep 26, 2023

I added the connection of isResolved using a fake placeholder button. The changed made was to the topics controller (src/controllers/topics.js), adding the method to set the isResolved variable. Also, added the route for this controller method in the src/routes/index.js. This links to issue #67 but this issue is not resolved yet, because of GitHub action workflow test failure, thus it was merged, however test passing issues on GitHub is resolved by pull request #80.

@LujainAlMansoori LujainAlMansoori merged commit 223ea60 into main Sep 26, 2023
@LujainAlMansoori LujainAlMansoori changed the title Adding is resolved to backend Connected back end isResolved with front end isResolved placeholder button Sep 26, 2023
@mbfannan mbfannan added the incorrect workflow fixed by other pr this label is for pull requests that were resolved by other prs in terms of the action workflow label Oct 5, 2023
@mbfannan mbfannan added this to the Sprint 2 milestone Oct 5, 2023
@mbfannan mbfannan linked an issue Oct 5, 2023 that may be closed by this pull request
@mbfannan mbfannan added the enhancement New feature or request label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request incorrect workflow fixed by other pr this label is for pull requests that were resolved by other prs in terms of the action workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolving workflow permission error that occured in merged PR #75
2 participants