-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebooks for MOM6 analysis #190
Comments
This is such a good point. So this goes back to using xgcm and #164. Perhaps the xgcm grid configs should be somehow provided centrally by the cookboo for each model. Then all examples should be similar regardless of model’s native coordinates! This does suggest the all examples should use xgcm. I’d be in favour of that. Would make examples homogenized across models. It’s a major change though… (major changes are good thing but could seem bit intimidating). |
I’m not sure that my suggestion above is the best way forward. But it seems to me that duplicating the examples to work for MOM6 output would create double the amount of maintenance. Also people would update the mom5 version but not the mom6 version. It will be a nightmare and will certainly such a situation will provoke nightmares and disturb my sleep. |
For example, one can take the relative vorticity example and make it so that it works for both MOM5 and MOM6 output. Only method 3 (w |
I agree that using libraries like I would suggest adopting these, as they should make it much easier to use these recipes with other models. Clearly MOM6 would be one of these other models, and the one you want to explicitly support, but as we've heard It may be too ambitious to try and transition all recipes as @navidcy says. I agree as a first step a few recipes could be targeted and used as template for other recipes. As for having As a first step defining those grids in |
Who of the new mom6 users is planning to join the Hackathon v2.0? Perhaps we can tag them here to get a vibe of what's the best strategy forward? @julia-neme, @schmidt-christina, @AndyHoggANU, .... (others?) |
is Hangyu joining? is he on GitHub? |
I'll make an attempt to be there. |
I'll be there! |
Sorry I'm late to the party - I'll be there tomorrow! |
You are not late! There still ~21hrs until the party.... |
I like the idea of making recipes model-agnostic wherever we can, and Maybe we should require all new recipes in this repo to be model-agnostic (or at least MOM5 and MOM6 compatible), and include examples using both MOM5 and MOM6 data. That would require the existing MOM6 notebooks to be made MOM5 compatible before adding them here (and perhaps replacing equivalent MOM5 notebooks). Perhaps too much work though? Or perhaps as an interim measure we should have separate MOM5, MOM6 and Agnostic directories, and eliminate notebooks from the MOM5 and MOM6 dirs whenever they are replaced by an Agnostic equivalent? |
I like this. Notebooks should (most of the times) just deal with physics, not with models and model coordinates, etc!!! |
Having 3 directories is a good idea. That way people who are only familiar with one model can still contribute new scripts to their preferred model dir and others at some later stage can upgrade them to the agnostic directory. Keeping the barrier low for people to contribute is important or we won’t get many new notebooks. |
Perhaps Hackathon v3.0 will deal with making everything model agnostic. It would be the ideal, and it should --in principle-- just be adding 2-3 lines at the top of the notebook to create the correct xgcm grid. Then everybody would have to work with xgcm and it would be a joyful ride! But since not even us (me at least) are not as comfortable doing so with both models we can't expect everybody else to do it. They don't have any example to follow. A task for this hackathon would be to make 1 or 2 notebooks model agnostic. I'll put it forward tomorrow morning see if anybody picks it up. Then by Hackathon v3.0 we'd probably have lots of examples of both models and we'd be ready for the "Complete MOM-model agnostic COSIMA Revolution!" |
Happy to work on something here. I'll do a notebook on the barotropic streamfunction, and examples of analysis you can do with that |
I can work on that as well |
I've got a KE decomposition notebook for MOM6 which I based on the MOM5 COSIMA one. I could clean this up to be more readable. |
I think some people may want to listen in to the tutorials and we are all in one room at ANU. Maybe MOM6 people could start working on individual Documented Examples for now (say here which you are doing). And then after the tutorials we can meet in breakout to discuss how to do the model agnostic thing? |
Ok, I start with Zonally_Averaged_Global_Meridional_Overturning_Circulation.ipynb |
Oh - @schmidt-christina - snap. |
I'll work on the regional model script. @angus-g I think it's still waiting for that pull request though. Were some changes you wanted made that I could implement? |
Actually, @schmidt-christina - maybe we can both have a go and see how different it is!! |
There's a few of us in Hobart in a breakout room. Is there a zoom link? |
I'll try to do something about how to plot transects and vertical layers |
Hi @ChrisC28 - let's listen to Angus' GitHub thing then break out. |
@ChrisC28 it's just the usual COSIMA meeting zoom link, Just click on breakouts and join room 1. |
A few of us in Hobart are looking revisiting the set of scripts made by @angus-g and @ashjbarnes to setup a regional configuration, and make them a little more general. We might look at generallising the horizontal resolution. Any takers? |
Sorry, having some problems with zoom. |
Julia and I will join the break out room in a minute |
We are in room 1 |
|
The MOM6 breakout decided that after the hackathon we will restructure the examples as:
Same 3 directories for Contributed_Examples |
how about
|
I'm happy with either structure. |
Who will do this? I don't want to mess it up, but I have a notebook ready for mom6 |
You can create a PR with your notebook in the |
Streamfunction was pushed :) |
Closing this issue, so we can start with a clean issue #331 for Hackathon 4.0. |
It would be great to have all of the Documented Examples also work for MOM6 output (i.e. with the different grid and diagnostic/coordinate variable names). I'm not sure what the best way to do this is. Do we make a whole new set of Documented Examples? Or can we somehow put a model option at the top of the notebook and it translates variable names and grids for us?
There are some existing COSIMA notebooks for MOM6 analysis here. Should we merge these with the cosima-recipes so people can find them? There are also a bunch of MOM6 notebooks developed by GFDL folks, e.g. here.
The text was updated successfully, but these errors were encountered: