Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DPMS. #1618

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Add support for DPMS. #1618

wants to merge 4 commits into from

Conversation

bukinr
Copy link
Member

@bukinr bukinr commented Jan 9, 2023

No description provided.

@@ -182,6 +182,19 @@ komeda_plane_atomic_disable(struct drm_plane *plane,
dprintf("%s\n", __func__);
}

void
dou_ds_control(struct komeda_drm_softc *sc, bool enable)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ds_control but BS_CONTROL?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess same as dou_ds_timing_setup...

@bukinr bukinr force-pushed the dpms branch 3 times, most recently from b50228a to fc0e9f0 Compare January 10, 2023 22:59
@brooksdavis
Copy link
Member

Moving the last commit to the beginning and never misnaming dou_bs_control() probably makes sense. The "o" bullets in the last commit message are odd.

@jrtc27
Copy link
Member

jrtc27 commented Jan 11, 2023

First two commits should also be reordered; fix the function before adding to it

@bukinr
Copy link
Member Author

bukinr commented Jan 11, 2023

I dont see why commits have to be re-ordered

driver. Also disable pixel clock and pipeline components in Komeda driver.
This puts devices into lower power mode and blanks the screen.
display mode straight from bridge_mode_set() as it should be.
@bsdjhb bsdjhb mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants