forked from fluxnet/ONEFlux
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularised and tested MATLAB code (ustar_cp) #35
Draft
dorchard
wants to merge
506
commits into
main
Choose a base branch
from
ustar_cp_refactor_main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorchard
modified the milestones:
Modularised all MATLAB code,
Units testing on all MATLAB modules
Sep 26, 2024
Note that we are focussing on the '4Season' pathway for the moment and then we will try to unify these with the non 4season version which have a small delta. |
ma595
pushed a commit
that referenced
this pull request
Oct 17, 2024
energy_proc quality flags bugfixes:
Test fcDatetick
Add unit tests for fcBin function
Test fcNaniqr
Translation to Python by Peter Isaac.
Refactor and Test cpdEvaluate Initial Pass Refactored, tested and translated 'leaf*' functions of the Matlab code *Functions without dependencies that need to be translated also Initial pass of translation is to translate 'leaf' functions which are not dependent on calling functions which also need to be translated
…pdEvaluate"" This reverts commit 0076418. Reverted the 'revert' which takes the codebase back to incorrectly merged state of the code. Future new commit will fix this
…pCp3 Test and refactor cpd fmax2p cp3 Developed tests for cpdFmax2pCp3 Modularised cpdFmax2pCp3 Converted all modularised code to python Partial implementation to tests for function sub modules
Unit tests and python for fcDoy
Rename files which had the same name but different capitalisations. Causes issues on case-insensitive file systems like mac
Python translation of fcr2Calc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR collects all the progress on writing a comprehensive test suite for the MATLAB code along with modularised version of the MATLAB for even more fine-grained input-output testing.
188 cpdEvaluateUStarTh20100901.m(as we will use the 4Season instead)136 cpdBootstrapUStarTh20100901.m113 runCpdBootstrapUStarTh4Season20100901CAF.mSome of these below may be superfluous- check that it's used first.
70 fcFigLoc.m