Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularised and tested MATLAB code (ustar_cp) #35

Draft
wants to merge 506 commits into
base: main
Choose a base branch
from

Conversation

dorchard
Copy link
Member

@dorchard dorchard commented Sep 26, 2024

This PR collects all the progress on writing a comprehensive test suite for the MATLAB code along with modularised version of the MATLAB for even more fine-grained input-output testing.

  • 375 launch.m
    • Tests
    • Refactored
    • Translated
  • 231 cpdAssignUStarTh20100901.m @j-emberton
    • Tests
    • Refactored
    • Translated
  • 188 cpdEvaluateUStarTh20100901.m (as we will use the 4Season instead)
  • 184 cpdEvaluateUStarTh4Season20100901.m @isaacaka
    • Tests
    • Refactored
    • Translated
  • 179 cpdFindChangePoint20100901.m @isaacaka
    • Tests
    • Refactored
    • Translated
  • 146 cpdBootstrapUStarTh4Season20100901.m
    • Tests
    • Refactored
    • Translated
  • 136 cpdBootstrapUStarTh20100901.m
  • 113 runCpdBootstrapUStarTh4Season20100901CAF.m

Some of these below may be superfluous- check that it's used first.

  • 70 fcFigLoc.m
  • 68 fcDatetick.m @dorchard
    • Tests
    • Refactored
    • Translated
  • 62 fcBin.m @dorchard
    • Tests
    • Refactored
    • Translated
  • 61 cpdFmax2pCp3.m @j-emberton
    • Tests
    • Refactored
    • Translated
  • 60 fcNaniqr.m @j-emberton
    • Tests
    • Refactored
    • Translated
  • 52 cpdFmax2pCp2.m @j-emberton
    • Tests
    • Refactored
    • Translated
  • 23 fcReadFields.m @j-emberton
    • Tests
    • Refactored
    • Translated
  • 19 fcDoy.m @dorchard
    • Tests
    • Refactored
    • Translated
  • 19 fcDatevec.m @dorchard
    • Tests
    • Refactored
    • Translated
  • 11 fcr2Calc.m @dorchard
    • Tests
    • Refactored
    • Translated
  • 6 fcEqnAnnualSine.m @j-emberton
    • Tests
    • Refactored
    • Translated
  • 5 fcx2colvec.m @j-emberton
    • Tests
    • Refactored
    • Translated
  • 2 fcx2rowvec.m @j-emberton
    • Tests
    • Refactored
    • Translated

@dorchard
Copy link
Member Author

Note that we are focussing on the '4Season' pathway for the moment and then we will try to unify these with the non 4season version which have a small delta.

ma595 pushed a commit that referenced this pull request Oct 17, 2024
j-emberton and others added 30 commits January 3, 2025 18:03
Refactor and Test cpdEvaluate Initial Pass

Refactored, tested and translated 'leaf*' functions of the Matlab code

*Functions without dependencies that need to be translated also

Initial pass of translation is to translate 'leaf' functions which are not dependent on calling functions which also need to be translated
This reverts commit f3ab09e, reversing
changes made to 6f6bb8b.

There was an incorrect resolution of merge conflicts which deleted necessary code from the main branch
…pdEvaluate""

This reverts commit 0076418.

Reverted the 'revert' which takes the codebase back to incorrectly merged state of the code.
Future new commit will fix this
…pCp3

Test and refactor cpd fmax2p cp3

Developed tests for cpdFmax2pCp3
Modularised cpdFmax2pCp3
Converted all modularised code to python
Partial implementation to tests for function sub modules
Unit tests and python for fcDoy
Rename files which had the same name but different capitalisations. Causes issues on case-insensitive file systems like mac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants