[ENG-5012][ENG-5014] Updates to see the file version for the latest preprint deploy #2075
Conversation
Pull Request Test Coverage Report for Build 7134599248Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
| <div local-class='file-renderer-container {{if this.isMobile 'mobile'}}'> | ||
| <div local-class='file-container'> | ||
| <FileRenderer | ||
| @allowCommenting={{this.allowCommenting}} |
There was a problem hiding this comment.
It seems like FileRenderer isn't doing anything with this new parameter here. It looks like it was used to determine if we needed to do a postMessage?
There was a problem hiding this comment.
I was planning on tackling this after the hot fix since it's not part of the issue right now. I can fix it now.
There was a problem hiding this comment.
We can address it in a separate JIRA ticket/PR if it doesn't seem easy to implement. I'll leave that call up to you
There was a problem hiding this comment.
I fixed it in this PR.
There was a problem hiding this comment.
I don't think the allowCommenting parameter is being used to enable Hypothesis though. I'm not the most familiar with how Hypothesis works, but in ember-osf, there is some window.postMessage being done based on allowCommenting. I'll reach out to others who may be more familiar with how this works to see what needs to be done
bp-cos
changed the title
…he tests" This reverts commit 3b274d8.
futa-ikeda
changed the title
…reprint deploy (#2075) * Updates to see the file version * Added mobile formatting, a trait for different images * Fixed the sorting and versioning on the file versions * Updates per the PR * Updated the file-renderer to use "allowCommenting". Updated the tests * Revert "Updated the file-renderer to use "allowCommenting". Updated the tests" This reverts commit 3b274d8. * Fixed all the issues from the PR * Fixed the date created issue * A few minor fixes
…reprint deploy (CenterForOpenScience#2075) * Updates to see the file version * Added mobile formatting, a trait for different images * Fixed the sorting and versioning on the file versions * Updates per the PR * Updated the file-renderer to use "allowCommenting". Updated the tests * Revert "Updated the file-renderer to use "allowCommenting". Updated the tests" This reverts commit 3b274d8. * Fixed all the issues from the PR * Fixed the date created issue * A few minor fixes
Purpose
The file name, version and ability to download a different version was not included with the latest release
Summary of Changes
Ported the "file renderer" component from OSF Preprints
Screenshot(s)
Side Effects
N/A
QA Notes
This is challenging to test locally because the MFR does not work.