Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-5012][ENG-5014] Updates to see the file version for the latest preprint deploy #2075
[ENG-5012][ENG-5014] Updates to see the file version for the latest preprint deploy #2075
Changes from all commits
6b2d14c
317eb91
24c59df
5f88afb
3b274d8
e34d0d4
5a468ed
3934dbc
faf045c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like
FileRenderer
isn't doing anything with this new parameter here. It looks like it was used to determine if we needed to do apostMessage
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was planning on tackling this after the hot fix since it's not part of the issue right now. I can fix it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can address it in a separate JIRA ticket/PR if it doesn't seem easy to implement. I'll leave that call up to you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the
allowCommenting
parameter is being used to enable Hypothesis though. I'm not the most familiar with how Hypothesis works, but in ember-osf, there is somewindow.postMessage
being done based onallowCommenting
. I'll reach out to others who may be more familiar with how this works to see what needs to be done