Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Text improvements & added localizations (Hl-1425 & HL-1486) #3451

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix: Text improvements & added localizations (Hl-1425 & HL-1486) #3451

wants to merge 5 commits into from

Conversation

JanneJuhola
Copy link
Collaborator

@JanneJuhola JanneJuhola commented Oct 22, 2024 •
edited
Loading

Description ✨

Better text for applicant when application opend for editing. Reminder that a resend is needed.
Added some missing localizations for handler change log.
Added localization for received application status.
However this status is not used in Applicant app, Mistake to add it there (and only in fi-file) corrected.
Text in test updated

Issues 🐛

HL-1425, HL-1486

@JanneJuhola JanneJuhola marked this pull request as draft October 22, 2024 06:57
@JanneJuhola JanneJuhola marked this pull request as ready for review October 22, 2024 07:02
@JanneJuhola JanneJuhola marked this pull request as draft October 22, 2024 07:54
@JanneJuhola JanneJuhola marked this pull request as ready for review October 22, 2024 07:57
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3451.api.dev.hel.ninja/healthz 🚀🚀🚀

@JanneJuhola JanneJuhola marked this pull request as draft October 23, 2024 06:28
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
41 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.8% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
50 New issues
8 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
27 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3451.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3451.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3451.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3451.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

TestCafe applicant result is failed for https://helsinkilisa-ui-pr3451.dev.hel.ninja 😿💢💥💥

@JanneJuhola JanneJuhola marked this pull request as ready for review October 23, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirtawast sirtawast Awaiting requested review from sirtawast

@rikuke rikuke Awaiting requested review from rikuke

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JanneJuhola @terovirtanen