Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Text improvements & added localizations (Hl-1425 & HL-1486) #3451

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix: Text improvements & added localizations (Hl-1425 & HL-1486) #3451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
64da311
Fix:better text for opening application for editing
JanneJuhola Oct 22, 2024
f47a341
Fix:missing localization for handler change log added
JanneJuhola Oct 22, 2024
f8c0e4f
Fix:missing localization for received application status
JanneJuhola Oct 22, 2024
1469e7b
Fix: Text in test updated
JanneJuhola Oct 22, 2024
797ef4e
Fix:to prev. commit: received status not used for applicant
JanneJuhola Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/benefit/applications/tests/test_applications_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1391,7 +1391,7 @@ def test_application_status_change_as_handler(
if to_status == ApplicationStatus.ADDITIONAL_INFORMATION_NEEDED:
assert application.messages.count() == 1
assert (
"Please make the corrections by 11.06.2021"
"Please make the corrections and send application again by 11.06.2021"
in application.messages.first().content
)
assert len(mailoutbox) == 1
Expand Down
2 changes: 1 addition & 1 deletion backend/benefit/locale/en/LC_MESSAGES/django.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1399,7 +1399,7 @@ msgstr "Swedish"

#, python-brace-format
msgid ""
"Your application has been opened for editing. Please make the corrections by "
"Your application has been opened for editing. Please make the corrections and send application again by "
"{additional_information_needed_by}, otherwise the application cannot be "
"processed."
msgstr ""
Expand Down
4 changes: 2 additions & 2 deletions backend/benefit/locale/fi/LC_MESSAGES/django.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1441,11 +1441,11 @@ msgstr "Ruotsi"

#, python-brace-format
msgid ""
"Your application has been opened for editing. Please make the corrections by "
"Your application has been opened for editing. Please make the corrections and send application again by "
"{additional_information_needed_by}, otherwise the application cannot be "
"processed."
msgstr ""
"Hakemuksesi on avattu muokattavaksi. Tee korjaukset viimeistään "
"Hakemuksesi on avattu muokattavaksi. Tee korjaukset ja lähetä lomake uudelleen viimeistään "
"{additional_information_needed_by} mennessä, muuten hakemusta ei voida "
"käsitellä."

Expand Down
4 changes: 2 additions & 2 deletions backend/benefit/locale/sv/LC_MESSAGES/django.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1466,11 +1466,11 @@ msgstr "Svenska"

#, python-brace-format
msgid ""
"Your application has been opened for editing. Please make the corrections by "
"Your application has been opened for editing. Please make the corrections and send application again by "
"{additional_information_needed_by}, otherwise the application cannot be "
"processed."
msgstr ""
"Din ansökan har öppnats för redigering. Gör ändringarna senast "
"Din ansökan har öppnats för redigering. Gör ändringarna och skicka ansökan igen senast "
"{additional_information_needed_by}, annars kan ansökan inte behandlas."

msgid ""
Expand Down
2 changes: 1 addition & 1 deletion backend/benefit/messages/automatic_messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
LOGGER = logging.getLogger(__name__)

APPLICATION_REOPENED_MESSAGE = _(
"Your application has been opened for editing. Please make the corrections by "
"Your application has been opened for editing. Please make the corrections and send application again by "
"{additional_information_needed_by}, otherwise the application cannot be processed."
)

Expand Down
16 changes: 16 additions & 0 deletions frontend/benefit/handler/public/locales/en/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,6 +740,7 @@
"accepted": "Hakemus on hyväksytty ja Helsinki-lisää on myönnetty aikavälille {{dateRangeStart}} – {{dateRangeEnd}}",
"rejected": "Hakemus on hylätty. Helsinki-lisää ei myönnetä.",
"handling": "Hakemus on käsittelyssä.",
"received": "Hakemus on vastaanotettu.",
"cancelled": "Hakemus on peruttu.",
"additional_information_needed": "Hakemus on käsittelyssä."
},
Expand Down Expand Up @@ -1819,6 +1820,21 @@
},
"handledByAhjoAutomation": {
"label": "Käsitelty Ahjo automaatiolla"
},
"officialCompanyStreetAddress": {
"label": "Katuosoite"
},
"companyName": {
"label": "Työantaja"
},
"officialCompanyPostcode": {
"label": "Postinumero"
},
"officialCompanyCity": {
"label": "Postitoimipaikka"
},
"companyForm": {
"label": "Yritysmuoto"
}
}
}
Expand Down
16 changes: 16 additions & 0 deletions frontend/benefit/handler/public/locales/fi/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,6 +740,7 @@
"accepted": "Hakemus on hyväksytty ja Helsinki-lisää on myönnetty aikavälille {{dateRangeStart}} – {{dateRangeEnd}}",
"rejected": "Hakemus on hylätty. Helsinki-lisää ei myönnetä.",
"handling": "Hakemus on käsittelyssä.",
"received": "Hakemus on vastaanotettu.",
"cancelled": "Hakemus on peruttu.",
"additional_information_needed": "Hakemus on käsittelyssä."
},
Expand Down Expand Up @@ -1818,6 +1819,21 @@
},
"handledByAhjoAutomation": {
"label": "Käsitelty Ahjo automaatiolla"
},
"officialCompanyStreetAddress": {
"label": "Katuosoite"
},
"companyName": {
"label": "Työantaja"
},
"officialCompanyPostcode": {
"label": "Postinumero"
},
"officialCompanyCity": {
"label": "Postitoimipaikka"
},
"companyForm": {
"label": "Yritysmuoto"
}
}
}
Expand Down
16 changes: 16 additions & 0 deletions frontend/benefit/handler/public/locales/sv/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,6 +740,7 @@
"accepted": "Hakemus on hyväksytty ja Helsinki-lisää on myönnetty aikavälille {{dateRangeStart}} – {{dateRangeEnd}}",
"rejected": "Hakemus on hylätty. Helsinki-lisää ei myönnetä.",
"handling": "Hakemus on käsittelyssä.",
"received": "Hakemus on vastaanotettu.",
"cancelled": "Hakemus on peruttu.",
"additional_information_needed": "Hakemus on käsittelyssä."
},
Expand Down Expand Up @@ -1819,6 +1820,21 @@
},
"handledByAhjoAutomation": {
"label": "Käsitelty Ahjo automaatiolla"
},
"officialCompanyStreetAddress": {
"label": "Katuosoite"
},
"companyName": {
"label": "Työantaja"
},
"officialCompanyPostcode": {
"label": "Postinumero"
},
"officialCompanyCity": {
"label": "Postitoimipaikka"
},
"companyForm": {
"label": "Yritysmuoto"
}
}
}
Expand Down
Loading