👌 IMPROVE: Create a functional landing page. #1420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brylie
requested changes
Oct 7, 2022
There was a problem hiding this comment.
This is looking good so far. I see only a couple of significant improvements currently.
- ensure the UI texts can be translated by adding the
translatetag to all English texts as was present on the previous home page. - keep the markup clean by removing the line and double-line breaks.
| </div> | ||
| <div class="msg-1"> | ||
| <h1 class="title"> | ||
| CiviWiki is a non-profit community working to develop a democratic engagement web system. |
There was a problem hiding this comment.
Add translate tag here
Suggested change
| CiviWiki is a non-profit community working to develop a democratic engagement web system. | |
| {% translate "CiviWiki is a non-profit community working to develop a democratic engagement web system." %} |
Comment on lines
+80
to
+83
| At CiviWiki we believe democracy works best when citizens are educated on issues and participate in the | ||
| democratic process. | ||
| We are a non-profit, non-partisan, community; working to build an open-source platform where citizens | ||
| discuss the problems they face, discover solutions, and enact change. |
There was a problem hiding this comment.
Add blocktranslate tag here.
Suggested change
| At CiviWiki we believe democracy works best when citizens are educated on issues and participate in the | |
| democratic process. | |
| We are a non-profit, non-partisan, community; working to build an open-source platform where citizens | |
| discuss the problems they face, discover solutions, and enact change. | |
| {% blocktranslate %} | |
| At CiviWiki we believe democracy works best when citizens are educated on issues and participate in the | |
| democratic process. | |
| We are a non-profit, non-partisan, community; working to build an open-source platform where citizens | |
| discuss the problems they face, discover solutions, and enact change. | |
| {% endblocktranslate %} |
| </div><br><br><br> | ||
| <div class="video"> | ||
| <p class="video-text"> | ||
| Check out our short video describing CiviWiki... |
There was a problem hiding this comment.
Add translate tag here.
Suggested change
| Check out our short video describing CiviWiki... | |
| {% translate "Check out our short video describing CiviWiki..." %} |
| </p> | ||
| <iframe width="640" height="480"" src="https://www.youtube.com/embed/Ll4VZv4a8bE" frameborder="0" | ||
| allowfullscreen></iframe> | ||
| <p class="small-text">Video made by |
There was a problem hiding this comment.
Add translate tag here.
Suggested change
| <p class="small-text">Video made by | |
| <p class="small-text">{% translate "Video made by" %} |
| <div class="row"> | ||
| <div class="col s12 m6 center"> | ||
| <div class="why"> | ||
| <h1 class="title">Why CiviWiki?</h1> |
There was a problem hiding this comment.
Suggested change
| <h1 class="title">Why CiviWiki?</h1> | |
| <h1 class="title">{% translate "Why CiviWiki?"%}</h1> |
| <footer> | ||
| <table class="footer"> | ||
| <tr> | ||
| <th>Connect With Us</th> |
There was a problem hiding this comment.
Suggested change
| <th>Connect With Us</th> | |
| <th>{% translate "Connect With Us" %}</th> |
| <th>Developers</th> | ||
| </tr> | ||
| <tr> | ||
| <td><a class="body-link" href="mailto:[email protected]" target="_blank">Email</a></td> |
There was a problem hiding this comment.
Suggested change
| <td><a class="body-link" href="mailto:[email protected]" target="_blank">Email</a></td> |
| </tr> | ||
| <tr> | ||
| <td><a class="body-link" href="https://www.facebook.com/CiviWiki/" target="_blank">Facebook</a></td> | ||
| <td><a class="body-link" href="https://github.com/CiviWiki/OpenCiviWiki/issues" target="_blank">Open Issues</a></td> |
There was a problem hiding this comment.
Suggested change
| <td><a class="body-link" href="https://github.com/CiviWiki/OpenCiviWiki/issues" target="_blank">Open Issues</a></td> | |
| <td><a class="body-link" href="https://github.com/CiviWiki/OpenCiviWiki/issues" target="_blank">{% translate "Open Issues" %}</a></td> |
| </tr> | ||
| <tr> | ||
| <td><a class="body-link" href="https://twitter.com/civiwiki" target="_blank" rel="noopener noreferrer">Twitter</a></td> | ||
| <td><a class="body-link" href="https://waffle.io/CiviWiki/OpenCiviWiki" target="_blank" rel="noopener noreferrer">Development Roadmap</a></td> |
There was a problem hiding this comment.
Suggested change
| <td><a class="body-link" href="https://waffle.io/CiviWiki/OpenCiviWiki" target="_blank" rel="noopener noreferrer">Development Roadmap</a></td> | |
| <td><a class="body-link" href="https://waffle.io/CiviWiki/OpenCiviWiki" target="_blank" rel="noopener noreferrer">{% translate "Development Roadmap" %}</a></td> |
| </tr> | ||
| <tr> | ||
| <td> </td> | ||
| <td><a class="body-link" href="https://riot.im/app/#/room/#CiviWiki:matrix.org" target="_blank" rel="noopener noreferrer">Live Chat on Matrix</a></td> |
There was a problem hiding this comment.
Suggested change
| <td><a class="body-link" href="https://riot.im/app/#/room/#CiviWiki:matrix.org" target="_blank" rel="noopener noreferrer">Live Chat on Matrix</a></td> | |
| <td><a class="body-link" href="https://riot.im/app/#/room/#CiviWiki:matrix.org" target="_blank" rel="noopener noreferrer">{% translate "Live Chat on Matrix" %}</a></td> |
gorkemarslan
requested changes
Oct 8, 2022
Comment on lines
+179
to
+198
|
|
||
| /* .learn-more { | ||
| display: table; | ||
| margin: 3em auto 0; | ||
| padding: 1em 6em; | ||
| cursor: pointer; | ||
| border-radius: 3px; | ||
| box-shadow: inset 0 -3px 0 rgba(0, 0, 0, 0.8); | ||
| background: #eaaf00; | ||
| background-image: -webkit-linear-gradient(#eaaf00 0%, #d78100 100%); | ||
| font-size: 1.2em; | ||
| } | ||
|
|
||
| .learn-more:hover { | ||
| background: #eaaf00; | ||
| } | ||
|
|
||
| .learn-more:active { | ||
| box-shadow: inset 0 2px 0 rgba(0, 0, 0, 0.8); | ||
| } */ |
There was a problem hiding this comment.
Suggested change
| /* .learn-more { | |
| display: table; | |
| margin: 3em auto 0; | |
| padding: 1em 6em; | |
| cursor: pointer; | |
| border-radius: 3px; | |
| box-shadow: inset 0 -3px 0 rgba(0, 0, 0, 0.8); | |
| background: #eaaf00; | |
| background-image: -webkit-linear-gradient(#eaaf00 0%, #d78100 100%); | |
| font-size: 1.2em; | |
| } | |
| .learn-more:hover { | |
| background: #eaaf00; | |
| } | |
| .learn-more:active { | |
| box-shadow: inset 0 2px 0 rgba(0, 0, 0, 0.8); | |
| } */ |
| cursor: pointer; | ||
| color: white; | ||
| background-color: #6526de; | ||
| /* box-shadow: 0 0 4px #999; */ |
There was a problem hiding this comment.
Suggested change
| /* box-shadow: 0 0 4px #999; */ |
| top: 50%; | ||
| width: 24em; | ||
| margin: 0 auto; | ||
| /* border-right: 2px solid rgba(136, 16, 184, 0.75); */ |
There was a problem hiding this comment.
Suggested change
| /* border-right: 2px solid rgba(136, 16, 184, 0.75); */ |
| text-align: center; | ||
| white-space: nowrap; | ||
| overflow:hidden; | ||
| /* transform: translateY(-50%); */ |
There was a problem hiding this comment.
Suggested change
| /* transform: translateY(-50%); */ |
| .footer { | ||
| color: #eeeeee; | ||
| text-align: right; | ||
| /* padding: 2em; */ |
There was a problem hiding this comment.
Suggested change
| /* padding: 2em; */ |
gorkemarslan
requested changes
Oct 8, 2022
| font-size: 180%; | ||
| text-align: center; | ||
| white-space: nowrap; | ||
| overflow:hidden; |
There was a problem hiding this comment.
Could you use an online CSS beautifier tool to format the whole file?
brylie
requested changes
Oct 9, 2022
| .footer td { | ||
| padding-left: 10px; | ||
| padding-bottom: 2px; | ||
| } |
There was a problem hiding this comment.
Add a new line at the end of files :-)
Suggested change
| } | |
| } | |
|
@ApoorvaKashyap, will you be able to address any of the pull request review comments so we can merge this work into CiviWiki |
|
Hi |
|
Hi Brylie, I have been following this project for a few months. I would try to make a contribution. I noticed there are requested changes to this pull request that do not seem to have been completed. If you would like, I would be willing to incorporate the requested changes to try to help move this along. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1310. Improvement over PR #1367.
Description
This is a basic functional landing page, similar in function to the one displayed in the issue.
Here's a look:
