made some map operations consistent #86218
Triggered via pull request
January 30, 2025 13:59
PatrikLundell
Status
Cancelled
Total duration
1h 33m 26s
Artifacts
1
Annotations
8 errors
|
run-clang-tidy (directly-changed):
src/vehicle.cpp#L7934
return type 'const std::set<tripoint_bub_ms>' (aka 'const set<coords::coord_point_ob<tripoint, coords::origin::reality_bubble, coords::scale::map_square>>') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness [readability-const-return-type,-warnings-as-errors]
|
|
run-clang-tidy (directly-changed):
src/character_inventory.cpp#L334
parameter 'it' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param,-warnings-as-errors]
|
|
run-clang-tidy (directly-changed):
src/map.cpp#L378
'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true [clang-diagnostic-undefined-bool-conversion,-warnings-as-errors]
|
|
run-clang-tidy (directly-changed)
Process completed with exit code 123.
|
|
run-clang-tidy (indirectly-changed-other)
Canceling since a higher priority waiting request for 'clang-tidy-build-79423' exists
|
|
run-clang-tidy (indirectly-changed-other)
The operation was canceled.
|
|
run-clang-tidy (indirectly-changed-src)
Canceling since a higher priority waiting request for 'clang-tidy-build-79423' exists
|
|
run-clang-tidy (indirectly-changed-src)
The operation was canceled.
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
cata-analyzer-plugin
Expired
|
1.33 MB |
|