Tweaks for visibility checks regarding vehicles and furniture #77599
+7
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Tweaks for visibility checks regarding vehicles and furniture"
Purpose of change
Visibility checks checked only for
coverage
value of furniture (if any) on a given tile, even if there's a vehicle there. Flowers, being a furniture and havingTRANSPARENT
flag, gave 0% concealment. So if there's a flower underneath vehicle's closed doors, quarterpanels or other opaque part, you was able to see right through that part.I'm crouching here to narrow the field of view, in order to make the bug more demonstrative, but you have that visibility even when standing.
Also previous checks considered open doors as non-transparent if you were crouching.
Closes #49381.
Describe the solution
Describe alternatives you've considered
None.
Testing
Get vehicle, spawned dandelion under one of its closed doors. Crouched, checked that dandelion no longer makes me see through the door.
Opened door while crouched, checked that I can see through open door.
Additional context