Send debug messages to Windows debugger #78838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
|
PR can't pass a basic build test, and it doesn't look like a random test fail for me |
DebugFile hosts the ostream as a singleton. This is fine because debugFile() does the same. Maybe move it into DebugFile::init to capture the start.
Needed to not loose the initial message and to be able to use stderr in the tests.
DebugView will show newlines as additional empty lines, while the vscode debugger output will print them correctly.
alef
force-pushed
the
outputdebugstringa
branch
from
323f7fa to
e85438c
Compare
|
Going to have to fix fs -> std::filesystem. |
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Send debug messages to Windows debugger"
Purpose of change
In addition to
debug.log, send all debug messages to Windows debugger via OutputDebugStringA.Describe the solution
Add a wrapper class to intercept
streambufmethods. This will make possible to grow a string and flush toOutputDebugStringAlater.Not required, but also:
PATH_INFO::debugto acata_path, like othersDebugFileinterfacedebug.lognow and thenDescribe alternatives you've considered
None
Testing
Additional context
PR in draft because of some ideas want to work on later but still get some feedback.