-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CMake Linux VCPKG build #79104
Fix CMake Linux VCPKG build #79104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No opinion on the core static
->dynamic
switch (i have not tried building this on linux), but I have a couple of generic CMake nitpicks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just tested this and can confirm that MSVS VCPKG CMake build still works. So as long as it works for your Linux use case, it should be good to go.
LGTM
Ah, CI complains about
I can confirm that bare I should perhaps also have been more explicit in my above statement about this working on windows, I've only tested that |
Much clang failure. Is that related or just an artifact of previous build states? |
It's definitely related. It's failing trying to process the newly-added cmake directives (although i have not looked any deeper into this) |
b2fced2
to
5e4d0bc
Compare
Summary
Build "Fix CMake Linux VCPKG build"
Purpose of change
Fix CMake Linux VCPKG build
Describe the solution
There was a mismatch between VCPKG triplet and DYNAMIC_LINKING in the preset. This lead to a confusion of static linking targets used in dynamic.
Also add a CMake function to list the targets added by VCPKG.
Describe alternatives you've considered
Testing
To build, one has to remove
pdcurses
frommsvc-full-features/vcpkg.json
because it is a Windows-only package.Run the executable.
Additional context
The system hardcodes the
RPATH
to point to the build directory.