Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding different sizes for wooden wheel variants, and wooden casters set #79256

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Leha44581
Copy link

@Leha44581 Leha44581 commented Jan 20, 2025

Summary

Content "Added a set of wooden caster wheels, as a crude replacement to shopping cart caster wheels Also adds 8 inch, 12 inch, 16 inch wooden wheels"

Purpose of change

I think the player should be able to make more than just one size of wooden wheels

Describe the solution

Edited some jsons to add the new recipes/items/vehicleparts

Testing

The recipes seem to work fine, i have successfully repaired one shopping cart

Additional context

Wooden caster wheels are very much a real thing, and are often sold as "antique"
Antique+Cast+Iron+Industrial+Furniture+Stem+Casters+1b

Added a set of wooden caster wheels, as a potential crude replacement to shopping cart caster wheels
Also adds 8 inch, 12 inch, 16 inch wooden wheels
Copy link
Contributor

You are creating a pull request with the master branch as the head branch. This is completely fine if you plan to make contribution once or do not plan to do it often, but if you are interested in making multiple pull requests within a short span of time, this would prevent you from doing it comfortably. You may read https://docs.github.com/en/get-started/quickstart/contributing-to-projects#creating-a-branch-to-work-on for a typical workflow of contributing to a project on GitHub.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling new contributor labels Jan 20, 2025
@Leha44581 Leha44581 marked this pull request as draft January 20, 2025 03:43
@Leha44581 Leha44581 marked this pull request as ready for review January 20, 2025 03:48
@moxian
Copy link
Contributor

moxian commented Jan 20, 2025

The image you attach in the OP does not depict wooden casters - they are pretty clearly metallic, although the lightning makes it a bit ambiguous. Here's another shot of the same antique piece (from https://www.ironanarchy.com/furniture-casters/p/antique-furniture-stem-casters-double-wheel-3sj5j)

Antique+Cast+Iron+Industrial+Furniture+Stem+Casters+1a

From the same website, another set of casters, these ones are wooden but are definitely still in a metal frame: https://www.ironanarchy.com/furniture-casters/p/antique-swivel-furniture-casters-fkz57

Small+Antique+Cast+Iron+Stem+Furniture+Caster+Wheels,+Schenck+1a

Even assuming the housing was wooden, it looks a bit bigger than a 2x4 plank so can't be exactly carved out of it? I think? Also why does that recipe need a HAMMER quality?


Completely completely separately

I think the player should be able to make more than just one size of wooden wheels

Do you any of these different-sized wheels (aside from casters which are a different topic) be ever used?
As a player myself I would either 1) be confused about why do we have so many different sizes 2) wonder which size i need and 3) either choose the size that's "most optimal" (surely there's a most optimal one?) or 4) choose one completely at random. But in either case this choice feels pretty unsatisfying.
I could perhaps be fine with the different sized wooden if those were found items, where I don't have much of a choice and I'm just using whatever I have (and i don't care!), until i have something better (like what happens with half-wrecked cars and their parts). But this approach does not quite work when the player is forced to make the choice from the start.

@Leha44581
Copy link
Author

Leha44581 commented Jan 20, 2025

That is true, but i don't think a crude wooden housing would be very difficult to make
On the topic of size, i imagined them to look something like this but bigger, just with a wooden housing, which you definitely can carve out of a 2x4, assuming the wheel is about an inch thick
71LZWzREKxL UL500

About other wheels, i find the 20" option currently available in game to just not be very fitting for usecases besides a typical cart
16" Wheels can be used as a very crude car wheel replacement in a pinch, you also can make something like a wheelbarrow or a pull wagon which i just think is neat

Details

09f423cf2627796f64e06af9dfeefe8b
old-small-wooden-coach-full-of-summer-flowers-at-sunny-day-D7WT65

As far as optimization goes, they all have the same rolling resistance, so they're all pretty bad regardless of size

Hammer quality is valid, i will remove that requirement

Leha44581 and others added 6 commits January 20, 2025 08:26
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 20, 2025
@GuardianDll
Copy link
Member

GuardianDll commented Jan 20, 2025

([slow] [.],starting_items)=> (continued from above) ERROR : src/assign.cpp:19 [void report_strict_violation(const JsonObject &, const std::string &, const std::string_view)] (json-error)
Error: ([slow] [.],starting_items)=> cannot assign explicit value the same as default or inherited value

"difficulty": 4,
"time": "4 h",
"reversible": false,
            ▲▲▲
"autolearn": true,
"proficiencies": [ { "proficiency": "prof_carpentry_basic" } ],

Error: ([slow] [.],starting_items)=> Must use denomination for pricing. Valid units are:
cents
cent
dollars
dollar
USD
kUSD

"volume": "1500 ml",
"longest_side": "110 mm",
"price": 20000,
       ▲▲▲
"price_postapoc": 50,
"to_hit": -1,

tldr: remove "reversible": false,, and replace price and price_postapoc with a proper syntax

@moxian
Copy link
Contributor

moxian commented Jan 20, 2025

That is true, but i don't think a crude wooden housing would be very difficult to make
On the topic of size, i imagined them to look something like this but bigger, just with a wooden housing, which you definitely can carve out of a 2x4, assuming the wheel is about an inch thick

Being an inch thick helps (so 1" x 4") helps, yes.
Tbh I'm not super comfortable with either of the 2x4 housing orientation relative to the wheel. We either have the housing be sub 0.5"-thick on each side, OR we have the the bolt go within ~0.5" of the edge. These sizes work totally fine for wood housing, but I just don't quite trust wood to withstand that. See the crude pic, either the lenght A or the length B is a bit too short for comfort (not to scale)
image
But I guess, I can be convinced that it's fine, so consider this resolved.

However there's another issue I realize - we can't actually make the hole for the bolt with a wooden saw+sandpaper. We probably need a drilling tool in the mix.


About other wheels, i find the 20" option currently available in game to just not be very fitting for usecases besides a typical cart

That's valid!
But then do we really need six new wheel variants (three sizes × metal band on/off)? Can we have just one? I think both wheelbarrow and pull wagon would work just fine with 16"? And as it stands, there's pretty much no reason not to add metal bands, so the unbanded recipes would, again, go completely unused, which is a bad thing IMO.

Leha44581 and others added 3 commits January 20, 2025 19:12
- 8 Inch wooden wheels removed

- 12 Inch wooden wheels renamed into wheelbarrow wheels to not overwhelm the player, these are stable so an actual single wheeled wheelbarrow can be made

- 16 Inch wooden wheels renamed into small wooden cart wheels

- Added a hole drill requirement for all added wheels
@GuardianDll
Copy link
Member

[
  "wheel_wood_16i",
  "wheel_wood_12i",
  "wheel_wood_caster"
]
The item(s) above use legacy to_hit, please change them to the newer object
method (see /docs/design-balance-lore/GAME_BALANCE.md#to-hit-value) or remove
the to_hit field if the item(s) aren't intended to be used as weapons."
(~[slow] ~[.],starting_items)=>   CHECK( item_density( target ) <= max_density )
(~[slow] ~[.],starting_items)=> with expansion:
Error: (~[slow] ~[.],starting_items)=>   1.0f <= 0.85f
(~[slow] ~[.],starting_items)=> with messages:
(~[slow] ~[.],starting_items)=>   target.typeId() := string_id( "wheel_wood_caster" )
(~[slow] ~[.],starting_items)=>   target.weight() := 1500000mg
(~[slow] ~[.],starting_items)=>   target.volume() := 1500ml

@Maddremor
Copy link
Contributor

Have you ever wondered why old fashioned wagon wheels are so large compared to the smaller wheels we have on cars? It's because the smaller the wheel, the faster it needs to rotate for a given speed, and this is a problem when you don't have any fancy modern bearings to help you. A smaller wooden wheel might be reasonable, but I wouldn't put it on something like a caster since that would add mechanical complexity. A fixed wheel like that of a wheelbarrow can work for most circumstances.

If you really want to add something small-ish to make a primitive hand cart easier to drag around, then a sled runner of some kind would be the way to go, but for that we need to add flags or properties that keeps it from being used for steering or propulsion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions new contributor Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants