-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding different sizes for wooden wheel variants, and wooden casters set #79256
base: master
Are you sure you want to change the base?
Conversation
Added a set of wooden caster wheels, as a potential crude replacement to shopping cart caster wheels Also adds 8 inch, 12 inch, 16 inch wooden wheels
You are creating a pull request with the master branch as the head branch. This is completely fine if you plan to make contribution once or do not plan to do it often, but if you are interested in making multiple pull requests within a short span of time, this would prevent you from doing it comfortably. You may read https://docs.github.com/en/get-started/quickstart/contributing-to-projects#creating-a-branch-to-work-on for a typical workflow of contributing to a project on GitHub. |
The image you attach in the OP does not depict wooden casters - they are pretty clearly metallic, although the lightning makes it a bit ambiguous. Here's another shot of the same antique piece (from https://www.ironanarchy.com/furniture-casters/p/antique-furniture-stem-casters-double-wheel-3sj5j) From the same website, another set of casters, these ones are wooden but are definitely still in a metal frame: https://www.ironanarchy.com/furniture-casters/p/antique-swivel-furniture-casters-fkz57 Even assuming the housing was wooden, it looks a bit bigger than a 2x4 plank so can't be exactly carved out of it? I think? Also why does that recipe need a HAMMER quality? Completely completely separately
Do you any of these different-sized wheels (aside from casters which are a different topic) be ever used? |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
([slow] [.],starting_items)=> (continued from above) ERROR : src/assign.cpp:19 [void report_strict_violation(const JsonObject &, const std::string &, const std::string_view)] (json-error)
Error: ([slow] [.],starting_items)=> Must use denomination for pricing. Valid units are:
tldr: remove |
- 8 Inch wooden wheels removed - 12 Inch wooden wheels renamed into wheelbarrow wheels to not overwhelm the player, these are stable so an actual single wheeled wheelbarrow can be made - 16 Inch wooden wheels renamed into small wooden cart wheels - Added a hole drill requirement for all added wheels
|
Have you ever wondered why old fashioned wagon wheels are so large compared to the smaller wheels we have on cars? It's because the smaller the wheel, the faster it needs to rotate for a given speed, and this is a problem when you don't have any fancy modern bearings to help you. A smaller wooden wheel might be reasonable, but I wouldn't put it on something like a caster since that would add mechanical complexity. A fixed wheel like that of a wheelbarrow can work for most circumstances. If you really want to add something small-ish to make a primitive hand cart easier to drag around, then a sled runner of some kind would be the way to go, but for that we need to add flags or properties that keeps it from being used for steering or propulsion. |
Summary
Content "Added a set of wooden caster wheels, as a crude replacement to shopping cart caster wheels Also adds 8 inch, 12 inch, 16 inch wooden wheels"
Purpose of change
I think the player should be able to make more than just one size of wooden wheels
Describe the solution
Edited some jsons to add the new recipes/items/vehicleparts
Testing
The recipes seem to work fine, i have successfully repaired one shopping cart
Additional context
Wooden caster wheels are very much a real thing, and are often sold as "antique"