Mortars

[GuardianDll]

Summary

Content "Mortar. Like, the real one"

Purpose of change

I can

Describe the solution

TBD

Testing

TBD

Additional context

Draft because of #79291 (comment)

[github-actions]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• High-explosive mortar cartridge, designed to be used against troops, light vehicles, light bunkers or similar targets. Multioption fuse allows it to be set to function as proximity burst, impact burst, or delay burst.
• High-explosive mortar cartridge, designed to be used against troops, light vehicles, light bunkers or similar targets. Multioption fuse allows it to be set to function as proximity burst, impact burst, or delay burst. This one is more modern version, both more safe and more powerful.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary

• If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
• For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

[ehughsbaird]

I hope you are accepting reviews right now - just a few things I noticed.

[ehughsbaird]

It is probably better to use a translation than a raw string. It also is not extracted for translation (lang/string_extractor).

Suggested change

	std::string condition_fail_msg;
	translation condition_fail_msg;

[Procyonae]

diff --git a/lang/string_extractor/parsers/examine_action.py b/lang/string_extractor/parsers/examine_action.py
index 3e62ed3856..a689961d39 100644
--- a/lang/string_extractor/parsers/examine_action.py
+++ b/lang/string_extractor/parsers/examine_action.py
@@ -3,17 +3,20 @@ from .effect import parse_effect_on_condition


 def parse_examine_action(json, origin, name):
+    ename="{}'s examine action".format(name)
     if "query_msg" in json:
         write_text(json["query_msg"], origin,
-                   comment="Query message of {}".format(name))
+                   comment="Query message for {}".format(ename))
     if "success_msg" in json:
         write_text(json["success_msg"], origin,
-                   comment="Success message of {}".format(name))
+                   comment="Message when {} succeeds".format(ename))
     if "redundant_msg" in json:
         write_text(json["redundant_msg"], origin,
-                   comment="Redundant message of {}".format(name))
+                   comment="Message when {} would be redundant".format(ename))
+    if "condition_fail_msg" in json:
+        write_text(json["condition_fail_msg"], origin,
+                   comment="Message when {} fails its condition".format(ename))
     if "effect_on_conditions" in json:
         for eoc in json["effect_on_conditions"]:
             if type(eoc) is dict:
-                parse_effect_on_condition(eoc, origin,
-                                          "examine action of {}".format(name))
+                parse_effect_on_condition(eoc, origin, ename)

Adding the condition_fail_msg translation extraction and improving existing translation comments to make it more obvious what they relate to (longest line is 79 characters which is exactly the cap so hopefully flake8 is chill with the change)