-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Item groups don't spawn blacklisted items #79341
base: master
Are you sure you want to change the base?
Conversation
AFAIK item blacklist thing gets processed in Maybe my reasoning for a9bcfa1 isn't as solid as I thought, and it broke the blacklist logic? Update: No, generic guns still can prevent hwp modules from being spawned in item group |
Oh, might actually be only modifiers are affected? I guess I do need to start with test cases after all. |
I can only find that the |
|
…tents consistency
a97cab4
to
e086f4d
Compare
It appears to be a much simpler fix than initially anticipated, since the infrastructure for everything is already there, although I added another fix for another similar oversight. Still need tests for this, though. |
Summary
Bugfixes "Item groups don't spawn blacklisted items"
Purpose of change
In #79285 it came to light that blacklists weren't regarded with item group spawns.
Describe the solution
Add containers to item removal in item modifiers.
Also add containers to consistency check in item modifiers.
There's potential (and need honestly) for test cases here, but I want to see if it breaks existing tests before I work on that.
Describe alternatives you've considered
Testing
Ran tests with this PR on top of #79285 and
[force_load_game] --mods=dda,generic_guns
.Additional context