-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Xedra Evolved ] Casings from dreamsmith #79366
Merged
GuardianDll
merged 11 commits into
CleverRaven:master
from
Maleclypse:Dreamsmith-makes-casings
Jan 30, 2025
Merged
[Xedra Evolved ] Casings from dreamsmith #79366
GuardianDll
merged 11 commits into
CleverRaven:master
from
Maleclypse:Dreamsmith-makes-casings
Jan 30, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dreamforged_casings.json Casings
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Mods
Issues related to mods or modding
Monsters
Monsters both friendly and unfriendly.
Mods: Xedra Evolved
Anything to do with Xedra Evolved
astyled
astyled PR, label is assigned by github actions
labels
Jan 27, 2025
Maleclypse
commented
Jan 27, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Maleclypse
commented
Jan 27, 2025
Doesn't this transmute dreamdross into brass? |
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Jan 27, 2025
Yes but given that dreamdross is magickal brass, I'm fine with stripping it of the magickal part. |
Maleclypse
commented
Jan 28, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
and removed
json-styled
JSON lint passed, label assigned by github actions
labels
Jan 29, 2025
github-actions
bot
added
the
Spawn
Creatures, items, vehicles, locations appearing on map
label
Jan 29, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
and removed
json-styled
JSON lint passed, label assigned by github actions
labels
Jan 29, 2025
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mods: Xedra Evolved
Anything to do with Xedra Evolved
Mods
Issues related to mods or modding
Monsters
Monsters both friendly and unfriendly.
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dreamforged_casings.json
Casings
Summary
Mods "XE: Dreamsmith will learn casings if they are a shooter"
Purpose of change
Dreamsmith seems like the perfect place to add the ability to craft shell casings.
Describe the solution
Make recipes and eocs to learn them. There are several extraneous recipes I made that might make sense for a launchers based eoc or a rarities EOC that maybe a dreamsmith could learn to make from factions if they have several casins recipes already.
Describe alternatives you've considered
I should be working on the evil pawnshop but I saw this discussed in cdda-discussion.
Testing
Additional context