Improve efile i18n #79402
Draft
Improve efile i18n #79402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if out of bounds, add translator comments Maybe slightly overkill but it seemed silly splitting these up just to glue them together in the same function
github-actions
bot
added
[C++]
|
This is good, just make sure that "move onto/off" make sense in the UI. Example for selecting "move onto": Before these changes: It was confusing because moving files ONTO a device means that you're selecting files on devices to move OFF of in the UI and vice versa. In retrospect, this might not be necessary, you could just say "move files onto (device)" instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fixes #79371
The onto/off of messages appear to be the wrong way around
Describe the solution
Hopefully makes it more pleasant and possible to translate
Fixes onto/off of order
Describe alternatives you've considered
The "Merge the parts together" commit is probably unnecessary but seems nicer
Testing
Checked the move message log messages were right (I couldn't get copying to work period in order to test it)
Additional context